Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple owners on Lib: token not handled correctly when making regular token #47

Open
kwvanderlinde opened this issue Jan 26, 2022 · 0 comments

Comments

@kwvanderlinde
Copy link

kwvanderlinde commented Jan 26, 2022

Describe the bug
If multiple owners are assigned to a character's Lib: token, creating a new token for the character will result in the new token having a single owner which is a comma-separated list of the owners on the Lib: token.

To Reproduce
Steps to reproduce the behavior:

  1. Open the Edit Token dialog for a character's Lib: token.
    • Set multiple players as owners of a character's Lib: token (e.g., "player1" and "player2")
  2. Select the character in the compendium and click "Make Token".
  3. Find the newly created character token and edit it.
    • Go to the Ownership tab and see the a single owner whose name is a comma separate list (e.g., "player1,player2").

Expected behavior
All owners on the Lib: token should be copied to the new character token and should not be mangled together.

Screenshots
Here we can see I assigned myself ("kwvanderlinde") and some player ("player") as owners of the Lib: token:
image

And here we can see a brand new owner call "kwvanderlinde,player" has been set on the character token:
image

Desktop (please complete the following information):

  • OS: Linux Mint 20.3
  • Maptool Version 1.11.4
  • Framework Version: 2.5.6, seems to still be present on 2.5.7 as well

Additional context
I've already had to fix this for my own campaign as my players always use different names each time they connect 😅. It's as simple as editing Make Token@Lib:Character to use

getOwners("json",id,start)

instead of

getOwners(",",id,start)

The reason being that setOwner() only accepts JSON arrays if passing multiple owners.

At least that fixes my use case of making tokens via the Compendium. Don't know about other methods of making character tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant