Split Magic Items from Equipment Object

[git-steve-git]

Describe the bug
I've noticed that once I import a more complete list of magic items into the framework (I'm currently pulling DMG, XGE and TCE), the whole equipment panel gets REALLY SLOW to load. This affects all of the "tabs" (Weapons, Armor, Equipment Packs, etc) but I'm fairly sure it's just because the macro needs to scan the whole "Equipment" JSON, which is HUGE thanks to all the magic items I imported, no matter which tab you're trying to load.

I think performance could be greatly improved if this one giant Equipment JSON could be split in two: Equipment for all the non-magical stuff and Magic Items for all the magic stuff. Maybe also put the Magic Items table in its own window/macro.

I'm not sure how this would impact other places that magic items and non-magic items are mixed though (like the character sheet.)

To Reproduce

1. Go to Compendium, click one of the Equipment options (Weapons, Armor, etc)
2. wait for the equipment panel to load
3. close panel
4. go to Settings > Equipment
5. Import a JSON of all magic items from DMG
6. go back to Compendium and reopen the same tab as before.

Expected behavior
I've noticed that there's not a lot (if any) crossover between magic items and the other equipment sections, so if we could move all the magic items into their own JSON object (and maybe also put the Magic Items "tab" into its own widow) then I suspect the rest of the Equipment windows would load much faster even with a full dataset.

The GM may still need to deal with a long load time on the Magic Items window, but at least it would only be the GM affected, and only when he goes looking for Magic Items.

Desktop (please complete the following information):

• OS: Windows 10
• Maptool Version 1.7.0
• Framework Version 2.5.6

[rtakehara]

I'm not sure how this would impact other places that magic items and non-magic items are mixed though (like the character sheet.)

That's the main concern, one thing I could do is build some sort of index that scans and sorts everything and saves on a lighter structure (similar to how the bestiary works).

I've heard maptool 1.8 improves a lot on performance, so I will wait for that to come out and see if the problem solves itself.