Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter selector – existential filters [?@<path>] #154

Open
V0ldek opened this issue Jun 14, 2023 · 1 comment
Open

Filter selector – existential filters [?@<path>] #154

V0ldek opened this issue Jun 14, 2023 · 1 comment
Labels
acceptance: go ahead Reviewed, implementation can start area: selector Support for a JSONPath selector type: feature New feature or request
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Jun 14, 2023

Is your feature request related to a problem? Please describe.
Support for filters with the following restrictions:

  • no nesting
  • no logical/boolean operations
  • only existential tests

So strictly filters of the form [?@<path>].

Describe the solution you'd like
The solution requires a theoretical write-up and then implementation.

The current idea is to have a second DFA, the filter automaton, controlled by the main query automaton. The state of the filter automaton would determine if a given path match is to be emitted, ingored, or stored to potentially be emitted later.

Additional context
RFC draft.
@V0ldek V0ldek added the type: feature New feature or request label Jun 14, 2023
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label Jun 14, 2023
@github-actions
Copy link

Tagging @V0ldek for notifications

@V0ldek V0ldek changed the title Filter selector &ndash; existential filters [?@<path>] Filter selector – existential filters [?@<path>] Jun 14, 2023
@V0ldek V0ldek mentioned this issue Jun 14, 2023
Open
@V0ldek V0ldek added this to the v1.0.0 milestone Jun 15, 2023
@github-actions github-actions bot added acceptance: go ahead Reviewed, implementation can start and removed acceptance: triage Waiting for owner's input labels Jun 15, 2023
@V0ldek V0ldek added mod: engine area: selector Support for a JSONPath selector labels Jun 15, 2023
@V0ldek V0ldek mentioned this issue Feb 28, 2024
Merged
3 tasks
V0ldek added a commit that referenced this issue Feb 28, 2024
@V0ldek
feat!: parsing filter expressions
4784a7e 
This is mainly an `rsonpath-syntax` change – the selectors are parsed, but `rq` will give you an unsupported error and a link to #154 if you put them in a query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acceptance: go ahead Reviewed, implementation can start area: selector Support for a JSONPath selector type: feature New feature or request
Projects
Active rq development
Status: Todo
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@V0ldek