Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop functions not considering photo orientation #608

Open
onegrasshopper opened this issue Jan 7, 2022 · 2 comments
Open

Crop functions not considering photo orientation #608

onegrasshopper opened this issue Jan 7, 2022 · 2 comments
Labels

Comments

@onegrasshopper
Copy link

Describe the bug
The current crop implementation seems to assume "AB" orientation photos only, not considering a photos getDevelopSettings()["orientation"] which could be "BC", "CD", or flipped, etc

This also affects the RatioCrop function in clientutilities.

Gives strange behavior on any photo not with AB orientation.

To Reproduce
Steps to reproduce the behavior:

  • Load a few different orientation photos
  • Any photo that has orientation ~= 'AB' will behave strange in any of the crop functions

Expected behavior
Consistent behavior

System(please complete the following information):

  • Lightroom version 11
  • MIDI2LR version 5.2
@wunditta
Copy link

As for now this cannot be fixed. The function returning the orientation (getDevelopSettings['Orientation']) seems to have a bug as it always returns 'nil'. So currently it is not possible to take the orientation into account within the plugin.

I reported a bug with Adobe for this.

@uio2pl
Copy link

uio2pl commented Jan 2, 2025

It seems that Adobe bug was fixed. Can it be fixed now in MIDI2LR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants