Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowing csv export to use custom parser #84

Merged
merged 1 commit into from
Sep 23, 2022
Merged

allowing csv export to use custom parser #84

merged 1 commit into from
Sep 23, 2022

Conversation

vsoch
Copy link
Contributor

@vsoch vsoch commented Sep 23, 2022 •
edited
Loading

@NickleDave here are fixes so the custom parser is re-enabled - I think what happened is I made it default for get_parser (before it would throw an exception to not be GitHub, etc) and that meant the logic needed to be changed to check the parser name and data (empty or not) to determine assembling the custom repository. I think I've fixed it here, and I've also fixed your data file so there aren't any erroneous imports, attached.

Let me know if this works for you!

copy-Bioacoustics-software.csv

Signed-off-by: vsoch [email protected]

@vsoch vsoch mentioned this pull request Sep 23, 2022
Closed
@NickleDave
Copy link

Thank you so much @vsoch.

I confirmed that this rescues the custom repo functionality, and I think makes the original intended fix from #79.

I now only get a handful of malformed entries:

ERROR:rse.utils.urls:Cannot find endpoint https://api.github.com/repos/tree/v0.6.5.
WARNING:rse.main.import.csv:Skipping malformed entry github.com/shyamblast/Koogu/tree/v0.6.5
ERROR:rse.utils.urls:Cannot find endpoint https://api.github.com/repos/rflachlanhub.io/Luscinia.
WARNING:rse.main.import.csv:Skipping malformed entry rflachlan.github.io/Luscinia/
ERROR:rse.utils.urls:Cannot find endpoint https://api.github.com/repos/ohun/index.html.
WARNING:rse.main.import.csv:Skipping malformed entry marce10.github.io/ohun/index.html

and by eye those look like we would expect them to fail since they are GitHub links but not pointing at the project itself.
I'm guessing those are the ones you fixed in the .csv?

Much appreciated.

@vsoch
Copy link
Contributor Author

vsoch commented Sep 23, 2022

Yep give a try of the one I included here :)

@NickleDave
Copy link

Yes I see now that those are in fact the ones you changed.

The one you included here runs perfectly. Life is good.

@vsoch
Copy link
Contributor Author

vsoch commented Sep 23, 2022

Life is good!!! <3

@vsoch vsoch merged commit 6343330 into master Sep 23, 2022
@vsoch vsoch deleted the fix/csv-sheet-import branch September 23, 2022 02:33
@vsoch
Copy link
Contributor Author

vsoch commented Sep 23, 2022

Released! https://pypi.org/project/rse/0.0.47/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not clear why malformed entries are malformed
2 participants
@vsoch @NickleDave