Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Prince version per project #42

Open
arthurattwell opened this issue Dec 14, 2021 · 0 comments
Open

Define Prince version per project #42

arthurattwell opened this issue Dec 14, 2021 · 0 comments

Comments

@arthurattwell
Copy link

Thank you for this great module. At Electric Book Works, we're beginning to use it to make setup easier for new team members (i.e. no separate Prince installation).

We have a further need: we need to be sure that, on a given project, every team member uses the same version of Prince. In our particular case, our extensive book-design CSS library was created for Prince 11, and isn't entirely compatible with later versions.

I've forked and modified node-prince to meet our needs in electricbookworks#1.

With those modifications, we can now set the Prince version we need in a project's package.json. Our node-prince checks for that before downloading Prince.

We're still testing this approach and may still find issues with it, though it's looking very promising so far.

Would you be interested in implementing this or something similar in your module? I'd be happy to PR my changes, though you might prefer a different approach. My Javascript skills are not as sophisticated as yours! It would certainly be better for us to use your module directly, rather than maintaining our own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant