Skip to content

RDM plot icons: _add_descriptor_icons() group offset scaling is negated #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JasperVanDenBosch opened this issue Nov 28, 2023 · 0 comments
Open

RDM plot icons: _add_descriptor_icons() group offset scaling is negated #378

JasperVanDenBosch opened this issue Nov 28, 2023 · 0 comments

Comments

@JasperVanDenBosch
Copy link
Contributor

To calculate the offset of a group of icons from the axis, a pixel value is calculated in a way such that the scaling is applied, then negated again:

rsatoolbox/src/rsatoolbox/vis/rdm_plot.py

Line 539 in 0f1e77a

offset = im_max_pix * size

This should probably be:

offset = (im_max_pix / icon_spacing) * size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JasperVanDenBosch