eep6174/9888: fix multibyte fields endians handling

Endians are not accounted for QCA6174/QCA9888 data formats, so we got
wrong length/checksum value on a BigEndian CPUs. Error also should
manifest themself with BigEndian encoded data on LittleEndian CPUs, but
I never saw BigEndian encoded data for these chips.

In order to correctly output multibyte field values utilizes the same
approach as was used for other EEPROM formats (e.g. AR5416, QCA9880,
etc.). Turn field endians to a native CPU endian during data checking
stage, before any prints. We still do not know location of the flag,
that indicates BigEndian encoded data, so assume that data is always
LittleEndian encoded. So we perform endian corrections only on BigEndian
hosts.

Fixes: d178e35 ("Add stub QCA6174 support")
Fixes: 73ecd8c ("Add stub QCA9888 support")

Author: rsa9000

eep_6174.c

@@ -61,6 +61,9 @@ static int eep_6174_check(struct atheepmgr *aem)
 	}
 
 	/**
+	 * Data could come in a compressed form, so calc checksum on the private
+	 * copy of the decomressed calibration data *before* endians fix.
+	 *
 	 * NB: take pointer another one time from container to avoid warning
 	 * about a *possible* unaligned access
 	 */
@@ -71,6 +74,17 @@ static int eep_6174_check(struct atheepmgr *aem)
 		return false;
 	}
 
+	/**
+	 * NB: we still do not know location of the BigEndian format flag, so
+	 * assume that data is always Little Endian.
+	 */
+	if (aem->host_is_be) {
+		printf("EEPROM Endianness is not native.. Changing.\n");
+
+		bswap_16_inplace(pBase->length);
+		bswap_16_inplace(pBase->checksum);
+	}
+
 	return true;
 }
 

eep_9888.c

@@ -61,6 +61,9 @@ static int eep_9888_check(struct atheepmgr *aem)
 	}
 
 	/**
+	 * Data could come in a compressed form, so calc checksum on the private
+	 * copy of the decomressed calibration data *before* endians fix.
+	 *
 	 * NB: take pointer another one time from container to avoid warning
 	 * about a *possible* unaligned access
 	 */
@@ -71,6 +74,17 @@ static int eep_9888_check(struct atheepmgr *aem)
 		return false;
 	}
 
+	/**
+	 * NB: we still do not know location of the BigEndian format flag, so
+	 * assume that data is always Little Endian.
+	 */
+	if (aem->host_is_be) {
+		printf("EEPROM Endianness is not native.. Changing.\n");
+
+		bswap_16_inplace(pBase->length);
+		bswap_16_inplace(pBase->checksum);
+	}
+
 	return true;
 }