Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

running conformance tests with panic=abort #389

Open
@koivunej

Description

@koivunej

In #386 a bug was left unnoticed since I hadn't been checking github actions warnings (there should always be six for the upload core dumps). It would of course be more visible if the ipfs-http was compiled with panic=abort in the CI for the conformance tests. I am not sure how this should/could be done. Of course it might be this would be even more helpful to have this behaviour while developing.

Background: We run "conformance tests" against the ipfs-http binary on non-cross builds. The tests are interface-ipfs-core and they are shared between the implementations. See conformance/ and the workflow for more info.

The number of warnings from the workflow could be decreased, but I dont think I'd still always read them: If possible, dragging the number of core dumps down to macosx only would be the best. Perhaps the upload should only happen on failures? At the moment it is executed always().

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions