Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error output for parse errors #43

Open
rrdelaney opened this issue Oct 4, 2017 · 2 comments
Open

Better error output for parse errors #43

rrdelaney opened this issue Oct 4, 2017 · 2 comments
Labels
enhancement good first issue help wanted
Projects
CLI

Comments

@rrdelaney
Copy link
Owner

Right now the parse errors are really bad:

Error: Parse_error.Error: undefined
    at Object.compile (/usr/local/lib/node_modules/reasonably-typed/lib/index.js:45:11)
    at fs.readFile (/usr/local/lib/node_modules/reasonably-typed/lib/cli.js:86:40)
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:503:3)

We should make this better. I'm thinking something like the codeframe errors we do now for Modulegen errors.
@kogai
Copy link
Contributor

kogai commented Mar 7, 2018

I'd like to tackle this, please?

@rrdelaney
Copy link
Owner Author

Go for it 😁 feel free to PM me on discord if you need any help!

@kogai kogai mentioned this issue Mar 9, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
CLI
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kogai @rrdelaney