Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APNS alerts with content_available not displayed #659

Closed
virusman opened this issue Oct 10, 2023 · 2 comments
Closed

APNS alerts with content_available not displayed #659

virusman opened this issue Oct 10, 2023 · 2 comments

Comments

@virusman
Copy link

virusman commented Oct 10, 2023

Describe the bug
APNS messages containaing both alert and content-available are not being rendered on devices

To Reproduce
Steps to reproduce the behavior:

  1. Set up an APNS (p8) app
  2. Send a message that contains both an alert and content-available set to 1.
  3. Observe that no message is displayed.
    If content-available is not set, it will work fine.

Expected behavior
Message should be displayed.

Logs and other output
Not applicable

System configuration (please complete the following information):

  • OS: macOS
  • OS version: 14.0
  • Ruby version: 3.1.4
  • Rails version: 7.0.4
  • Rpush version: 7.0.1

Additional context
The problem is this part of code, where the push type is explicitly set to background when content-available is set:
image
It should not be set to background if alert is present.

@benlangfeld
Copy link
Collaborator

Looks like I lost track of this in the past: #596 (comment)

@benlangfeld
Copy link
Collaborator

This is a duplicate of #647

@benlangfeld benlangfeld closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants