Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated RSpec version #530

Closed
wants to merge 2 commits into from
Closed

Updated RSpec version #530

wants to merge 2 commits into from

Conversation

yihyang
Copy link

@yihyang yihyang commented Oct 1, 2019

Fixed #529

Changes

  • Updated rspec version

@yihyang yihyang mentioned this pull request Oct 1, 2019
Open
@aried3r
Copy link
Member

aried3r commented Oct 3, 2019

Thanks for the PR! As you can see, sadly all Redis test runs don't work if RSpec is upgraded, sadly I don't know why exactly.

@yihyang
Copy link
Author

yihyang commented Oct 3, 2019

I see, I think there are already some errors on the current versions. However upgrading the RSpec caused it to fail. GIve me sometime to have a look if you are ok.

Check the existing PR: https://travis-ci.org/rpush/rpush/jobs/590578647
There are some error messages that actually occurred but was not enough to cause it to fail

@aried3r
Copy link
Member

aried3r commented Oct 8, 2019

That would be awesome, thank you!

benlangfeld
benlangfeld requested changes Sep 24, 2020
View reviewed changes
Copy link
Collaborator

@benlangfeld benlangfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yihyang , thanks for the contribution!

This includes a downgrade of Modis, which I don't think is desirable, and has some merge conflicts. Could you maybe resolve those two?

@aried3r
Copy link
Member

aried3r commented Sep 25, 2020

@benlangfeld, just for a little background, I tried a few times updating RSpec, but always failed due to obscure failures that IMO should not have been caused by a switch from 3.4 to 3.5. At least I couldn't find anything in the changelog of rspec that would suggest so.

I didn't want to invest the time to maybe even git-bisect through v3.4.0 to v3.5.0, but with rspec 4 being a thing, I assume this might make maintenance easier along the way.

@benlangfeld benlangfeld self-assigned this Sep 26, 2020
@aried3r
Copy link
Member

aried3r commented Oct 1, 2020

I'm closing this but will reopen if there's new activity.

@aried3r aried3r closed this Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangfeld benlangfeld benlangfeld requested changes

Assignees

@benlangfeld benlangfeld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update RSpec
3 participants
@yihyang @aried3r @benlangfeld