Skip to content

Commit 2bb2719

Browse files
committed
Implement play-test feedback.
1 parent 681a4d3 commit 2bb2719

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

.babelrc

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ You'll need to add the following 2 string values
33
inside the presets array:
44
55
1. "@babel/preset-env"
6-
2. "@babel/preset-react"
6+
2. For the second one, go back to the `react-babel` script you wrote in package.json. Take that preset and include it in the presets array below as well.
77
8-
babel will use these (they are already npm installed via package.json)
8+
Babel, which is being used as a "loader" by webpack, will use these npm packages to handle transpiling jsx into browser-readable JavaScript. (you already installed these npm packages via package.json)
99
*/
1010

1111
{

client/dist/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
Both are available in the global scope.
5151
5252
The browser can't understand our react code in "/client/babel-src" because it includes JSX.
53-
Babel is a tool that will trasform (referred to as 'transpile') the code into javascript
53+
Babel is a tool that will transform (referred to as 'transpile') the code into javascript
5454
that the browser can parse and run.
5555
5656
Next, uncomment the 2 script tags for the react components below,

client/dist/lib/react-babel-hint.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@ And then, your next task will be revealed!
2727
2828
`
2929

30-
console.log(chalk.white.bgGreen(next))
30+
console.log(chalk.white(next))

server/index.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ app.use(express.static(path.join(__dirname, '../client/dist')));
88

99
app.listen(PORT, () => {
1010
console.log(`listening on ${PORT}`);
11-
console.log(chalk.yellow.bgGreen('\nWecome to UNPACK.', '\n'));
12-
console.log(chalk.yellow.bgBlue('Follow the instuctions that are revealed at each step.\nIt will lead you through the codebase.\nYou\'ll see a playable video game in the browser after completing the final step!', '\n'));
13-
console.log(chalk.red.bgYellow.bold('This server doesn\'t do anything, aside from serving the static assets we\'ll need'));
14-
console.log(chalk.blue.bgYellow('NEXT: Open your browser and navigate to localhost:3000'));
11+
console.log(chalk.yellow('\nWecome to UNPACK.', '\n'));
12+
console.log(chalk.yellow('Follow the instuctions that are revealed at each step.\nIt will lead you through the codebase.\nYou\'ll get a playable video game in the browser\nafter completing the final step!', '\n'));
13+
console.log(chalk.red.bold('This server doesn\'t do anything, aside from serving the static assets we\'ll need'));
14+
console.log(chalk.yellowBright.underline('NEXT: Open your browser and navigate to http://localhost:3000'));
1515
});

webpack.config.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,17 @@ setTimeout(()=> {
1818

1919
// Update this variable below to point to the folder with the file
2020
// that will be webpack's "entry point".
21-
// This is the first file that webpack puts into its final bundle,
22-
// as well as any dependencies reference by the file. Such as: other files,
23-
// npm modules, images, or css.
21+
// This is the first file that webpack puts into the "bundle.js" file it is creating.
22+
// Webpack will then create a "dependency graph", bundling any dependencies
23+
// referenced by the file. Such as: other files, npm modules, images, or css.
24+
// see https://webpack.js.org/concepts/dependency-graph/
2425
// Have this variable resolve to the "webpack-src" folder inside of "./client"
25-
var SRC_DIR = path.join(__dirname, 'edit this value according to the above');
26+
var SRC_DIR = path.join(__dirname, 'edit this value according to the paragraph above');
2627

2728
// Update this next variable to point to the folder
2829
// where webpack will write the final bundled file.
2930
// Have this variable resolve to the "dist" folder inside of "./client"
30-
var DIST_DIR = path.join(__dirname, 'edit this value according to the above');
31+
var DIST_DIR = path.join(__dirname, 'edit this value according to the paragraph above');
3132

3233

3334
module.exports = {

0 commit comments

Comments
 (0)