Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zenspider/warnings double loads and fixes #1962

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Zenspider/warnings double loads and fixes #1962

wants to merge 12 commits into from

Commits on May 7, 2023

  1. Allow warnings in test if ENV["VERBOSE"] 

    (no good way to set $VERBOSE from the outside)
    @zenspider
    zenspider committed May 7, 2023
    Configuration menu
    Copy the full SHA
    eec7600 View commit details
    Browse the repository at this point in the history

  2. Use #to_s to check for loaded lexers to avoid double loads. 

    Drops `rake check:specs VERBOSE=1` from 331 lines to 144.
    @zenspider
    zenspider committed May 7, 2023
    Configuration menu
    Copy the full SHA
    35f8a97 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Fix double load warnings by using require_relative 

    load will load, always. Don't use it unless you really really mean it.
    @zenspider
    zenspider committed May 10, 2023
    Configuration menu
    Copy the full SHA
    edf5574 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate range regexp warnings

    @zenspider
    zenspider committed May 10, 2023
    Configuration menu
    Copy the full SHA
    ea56f89 View commit details
    Browse the repository at this point in the history

  3. Fix regexp in make... I'm not comfortable with this change and want i… 

    …t checked
    @zenspider
    zenspider committed May 10, 2023
    Configuration menu
    Copy the full SHA
    1455291 View commit details
    Browse the repository at this point in the history

  4. Fix warnings about private_class_method usage

    @zenspider
    zenspider committed May 10, 2023
    Configuration menu
    Copy the full SHA
    df4fb6c View commit details
    Browse the repository at this point in the history

  5. Unused variable warnings 

    Most of these should just be removed instead of underscored... but I
want eyeballs on this first. Some aren't being used the way they think
they're being used.
    @zenspider
    zenspider committed May 10, 2023
    Configuration menu
    Copy the full SHA
    a186bc6 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Fixed a LOT of warnings from scala. 

    Turns out it was one local variable used in a lot of regexps. This
updates the link to the reference and fixes it per reference.
    @zenspider
    zenspider committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8d8b623 View commit details
    Browse the repository at this point in the history

  2. Strip trailing whitespace from changelog.rake

    @zenspider
    zenspider committed May 11, 2023
    Configuration menu
    Copy the full SHA
    3648a1d View commit details
    Browse the repository at this point in the history

  3. Move require git inside of Rogue::Tasks::Git#initialize to make it lazy 

    git gem has warnings, this quells them
    @zenspider
    zenspider committed May 11, 2023
    Configuration menu
    Copy the full SHA
    d8146a6 View commit details
    Browse the repository at this point in the history

  4. Move several gems in Gemfile into development group to avoid eager re… 

    …quire

Bundler shouldn't require everything. Slows down the world.
    @zenspider
    zenspider committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8e6150a View commit details
    Browse the repository at this point in the history

  5. Removed unnecessary require of minitest/spec

    @zenspider
    zenspider committed May 11, 2023
    Configuration menu
    Copy the full SHA
    8a67ee1 View commit details
    Browse the repository at this point in the history