Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor autocomplete component #7957

Merged
merged 3 commits into from
May 28, 2024

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@lukicenturi lukicenturi force-pushed the refactor-autocomplete branch 9 times, most recently from 0e219c9 to 72cc7de Compare May 24, 2024 15:26
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 57.40319% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 53.77%. Comparing base (254a1f1) to head (af43a30).
Report is 1 commits behind head on develop.

Files Patch % Lines
...ontend/app/src/components/import/GroupedImport.vue 0.00% 34 Missing ⚠️
.../components/helper/filter/ValidatorFilterInput.vue 0.00% 13 Missing ⚠️
frontend/app/src/components/defi/Borrowing.vue 0.00% 12 Missing ⚠️
...pp/src/components/helper/LiquidityPoolSelector.vue 0.00% 12 Missing ⚠️
.../components/account-management/login/LoginForm.vue 0.00% 11 Missing ⚠️
...d/app/src/components/defi/DefiProtocolSelector.vue 0.00% 11 Missing ⚠️
...app/src/components/helper/BinancePairsSelector.vue 0.00% 10 Missing ⚠️
...pp/src/components/settings/explorers/Explorers.vue 0.00% 10 Missing ⚠️
...ontend/app/src/components/inputs/ExchangeInput.vue 0.00% 8 Missing ⚠️
frontend/app/src/pages/balances/exchange/index.vue 0.00% 8 Missing ⚠️
... and 21 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7957       +/-   ##
============================================
- Coverage    80.98%   53.77%   -27.21%     
============================================
  Files         1202     1656      +454     
  Lines       108784   166411    +57627     
  Branches     13037    13513      +476     
============================================
+ Hits         88101    89491     +1390     
- Misses       18408    74645    +56237     
  Partials      2275     2275               
Flag Coverage Δ
frontend_integration 59.86% <ø> (+0.10%) ⬆️
frontend_unit 38.86% <57.40%> (-40.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukicenturi lukicenturi force-pushed the refactor-autocomplete branch 3 times, most recently from a7ec824 to b938034 Compare May 27, 2024 06:08
@lukicenturi lukicenturi marked this pull request as ready for review May 27, 2024 07:59
@kelsos
Copy link
Member

kelsos commented May 27, 2024

image

We should probably make sure that the background is consistent

@lukicenturi
Copy link
Contributor Author

image

We should probably make sure that the background is consistent

updated

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @lukicenturi thanks :)

@kelsos kelsos merged commit f788413 into rotki:develop May 28, 2024
14 checks passed
@kelsos kelsos deleted the refactor-autocomplete branch May 28, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants