New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin taproot #7907

Open

yabirgb opened this issue May 8, 2024 · 0 comments

Milestone

Member

yabirgb commented May 8, 2024 •

edited

We have the same prefix bytes for taproot in our code

XPUB_TYPE_MAPPING_BYTES = {
    XpubType.P2PKH: b'\x04\x88\xb2\x1e',
    XpubType.P2SH_P2WPKH: b'\x04\x9d|\xb2',
    XpubType.WPKH: b'\x04\xb2GF',
    XpubType.P2TR: b'\x04\x88\xb2\x1e',
}

and when adding a xpub address the app changes the xpub type from p2tr to p2pkh when querying the added xpubs.

Task: properly keep track of the type for the xpub key and present it correctly to the user

yabirgb added this to the 1.33.1 milestone

LefterisJP changed the title ~~Bitcon taproot~~ Bitcoin taproot

yabirgb modified the milestones: 1.33.1, 1.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment