Skip to content

Commit

Permalink
Merge pull request #7980 from yabirgb/clean-classes
Browse files Browse the repository at this point in the history
Clean code
  • Loading branch information
yabirgb committed May 26, 2024
2 parents 400e475 + 34cf910 commit dc1cc4b
Show file tree
Hide file tree
Showing 9 changed files with 6 additions and 164 deletions.
21 changes: 1 addition & 20 deletions rotkehlchen/chain/arbitrum_one/modules/kyber/decoder.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,5 @@
from typing import TYPE_CHECKING

from rotkehlchen.chain.evm.decoding.kyber.decoder import KyberCommonDecoder


if TYPE_CHECKING:
from rotkehlchen.chain.arbitrum_one.node_inquirer import ArbitrumOneInquirer
from rotkehlchen.chain.evm.decoding.base import BaseDecoderTools
from rotkehlchen.user_messages import MessagesAggregator


class KyberDecoder(KyberCommonDecoder):

def __init__(
self,
evm_inquirer: 'ArbitrumOneInquirer',
base_tools: 'BaseDecoderTools',
msg_aggregator: 'MessagesAggregator',
) -> None:
super().__init__(
evm_inquirer=evm_inquirer,
base_tools=base_tools,
msg_aggregator=msg_aggregator,
)
...
20 changes: 1 addition & 19 deletions rotkehlchen/chain/base/modules/kyber/decoder.py
Original file line number Diff line number Diff line change
@@ -1,23 +1,5 @@
from typing import TYPE_CHECKING

from rotkehlchen.chain.evm.decoding.kyber.decoder import KyberCommonDecoder

if TYPE_CHECKING:
from rotkehlchen.chain.base.node_inquirer import BaseInquirer
from rotkehlchen.chain.evm.decoding.base import BaseDecoderTools
from rotkehlchen.user_messages import MessagesAggregator


class KyberDecoder(KyberCommonDecoder):

def __init__(
self,
evm_inquirer: 'BaseInquirer',
base_tools: 'BaseDecoderTools',
msg_aggregator: 'MessagesAggregator',
) -> None:
super().__init__(
evm_inquirer=evm_inquirer,
base_tools=base_tools,
msg_aggregator=msg_aggregator,
)
...
15 changes: 0 additions & 15 deletions rotkehlchen/chain/ethereum/modules/polygon/decoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,8 @@
from .constants import POLYGON_MIGRATION_ADDRESS

if TYPE_CHECKING:
from rotkehlchen.chain.evm.decoding.base import BaseDecoderTools
from rotkehlchen.chain.evm.node_inquirer import EvmNodeInquirer
from rotkehlchen.chain.evm.structures import EvmTxReceiptLog
from rotkehlchen.history.events.structures.evm_event import EvmEvent
from rotkehlchen.user_messages import MessagesAggregator

logger = logging.getLogger(__name__)
log = RotkehlchenLogsAdapter(logger)
Expand All @@ -38,18 +35,6 @@
class PolygonDecoder(DecoderInterface):
"""General polygon related decoder for ethereum mainnet. For now matic->pol migration"""

def __init__(
self,
evm_inquirer: 'EvmNodeInquirer',
base_tools: 'BaseDecoderTools',
msg_aggregator: 'MessagesAggregator',
) -> None:
super().__init__(
evm_inquirer=evm_inquirer,
base_tools=base_tools,
msg_aggregator=msg_aggregator,
)

def _decode_migration(self, context: DecoderContext) -> DecodingOutput:
"""Decode a MATIC -> POL migration"""
if context.tx_log.topics[0] != MIGRATED:
Expand Down
Empty file.
36 changes: 0 additions & 36 deletions rotkehlchen/chain/gnosis/modules/airdrops/decoder.py

This file was deleted.

18 changes: 1 addition & 17 deletions rotkehlchen/chain/gnosis/modules/sdai/decoder.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import TYPE_CHECKING, Any
from typing import Any

from rotkehlchen.chain.ethereum.utils import token_normalized_value_decimals
from rotkehlchen.chain.evm.decoding.constants import (
Expand All @@ -21,24 +21,8 @@

from rotkehlchen.chain.evm.constants import DEFAULT_TOKEN_DECIMALS # all tokens in this decoder use default(18) # noqa: E501 # isort: skip

if TYPE_CHECKING:
from rotkehlchen.chain.evm.decoding.base import BaseDecoderTools
from rotkehlchen.chain.gnosis.node_inquirer import GnosisInquirer
from rotkehlchen.user_messages import MessagesAggregator


class SdaiDecoder(DecoderInterface):
def __init__(
self,
gnosis_inquirer: 'GnosisInquirer',
base_tools: 'BaseDecoderTools',
msg_aggregator: 'MessagesAggregator',
) -> None:
super().__init__(
evm_inquirer=gnosis_inquirer,
base_tools=base_tools,
msg_aggregator=msg_aggregator,
)

def _decode_sdai_deposit_events(self, context: DecoderContext) -> DecodingOutput:
amount_raw = hex_or_bytes_to_int(context.tx_log.data[:32])
Expand Down
20 changes: 1 addition & 19 deletions rotkehlchen/chain/optimism/modules/kyber/decoder.py
Original file line number Diff line number Diff line change
@@ -1,23 +1,5 @@
from typing import TYPE_CHECKING

from rotkehlchen.chain.evm.decoding.kyber.decoder import KyberCommonDecoder

if TYPE_CHECKING:
from rotkehlchen.chain.evm.decoding.base import BaseDecoderTools
from rotkehlchen.chain.optimism.manager import OptimismInquirer
from rotkehlchen.user_messages import MessagesAggregator


class KyberDecoder(KyberCommonDecoder):

def __init__(
self,
evm_inquirer: 'OptimismInquirer',
base_tools: 'BaseDecoderTools',
msg_aggregator: 'MessagesAggregator',
) -> None:
super().__init__(
evm_inquirer=evm_inquirer,
base_tools=base_tools,
msg_aggregator=msg_aggregator,
)
...
20 changes: 1 addition & 19 deletions rotkehlchen/chain/polygon_pos/modules/kyber/decoder.py
Original file line number Diff line number Diff line change
@@ -1,23 +1,5 @@
from typing import TYPE_CHECKING

from rotkehlchen.chain.evm.decoding.kyber.decoder import KyberCommonDecoder

if TYPE_CHECKING:
from rotkehlchen.chain.evm.decoding.base import BaseDecoderTools
from rotkehlchen.chain.polygon_pos.node_inquirer import PolygonPOSInquirer
from rotkehlchen.user_messages import MessagesAggregator


class KyberDecoder(KyberCommonDecoder):

def __init__(
self,
evm_inquirer: 'PolygonPOSInquirer',
base_tools: 'BaseDecoderTools',
msg_aggregator: 'MessagesAggregator',
) -> None:
super().__init__(
evm_inquirer=evm_inquirer,
base_tools=base_tools,
msg_aggregator=msg_aggregator,
)
...
20 changes: 1 addition & 19 deletions rotkehlchen/chain/scroll/modules/kyber/decoder.py
Original file line number Diff line number Diff line change
@@ -1,23 +1,5 @@
from typing import TYPE_CHECKING

from rotkehlchen.chain.evm.decoding.kyber.decoder import KyberCommonDecoder

if TYPE_CHECKING:
from rotkehlchen.chain.evm.decoding.base import BaseDecoderTools
from rotkehlchen.chain.scroll.node_inquirer import ScrollInquirer
from rotkehlchen.user_messages import MessagesAggregator


class KyberDecoder(KyberCommonDecoder):

def __init__(
self,
evm_inquirer: 'ScrollInquirer',
base_tools: 'BaseDecoderTools',
msg_aggregator: 'MessagesAggregator',
) -> None:
super().__init__(
evm_inquirer=evm_inquirer,
base_tools=base_tools,
msg_aggregator=msg_aggregator,
)
...

0 comments on commit dc1cc4b

Please sign in to comment.