Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding doosan-robot2 to rosdistro #44527

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding doosan-robot2 to rosdistro #44527

wants to merge 1 commit into from

Conversation

song-ms
Copy link

@song-ms song-ms commented Feb 19, 2025

Please add the following dependency to the rosdep database.

Package name:

doosan-robot2

Purpose of using this:

To control all Doosan robot models

Links to Distribution Packages

The source is here:

https://github.com/doosan-robotics/doosan-robot2

Checks

  • [v ] All packages have a declared license in the package.xml
  • [v ] This repository has a LICENSE file
  • [v ] This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Feb 19, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@marcoag marcoag requested a review from cottsay February 20, 2025 10:58
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository contains packages which have names that are not appropriate for inclusion in the official ROS distribution index.

a0509_moveit_config
a0912_moveit_config
common2
dsr_bringup2
dsr_controller2
dsr_description2
dsr_gazebo2
dsr_hardware2
dsr_msgs2
dsr_tests
e0509_moveit_config
example
h2017_moveit_config
h2515_moveit_config
m0609_moveit_config
m0617_moveit_config
m1013_moveit_config
m1509_moveit_config
p3020_moveit_config
realtime_control
visualservoing

Package names like "example", "common2", or "realtime_control" do not accurately describe their association and must be renamed. In general, unless a package provides a de-facto implementation or interface for a particular concept, its name should contain something to identify the associated project or organization. For example, the dsr_* prefix is appropriate where used here.

@song-ms
Copy link
Author

song-ms commented Feb 27, 2025

Hello @cottsay

Thank you for your detailed guidance.

I have carefully reviewed the relevant sections and made the necessary modifications by adding the prefix "dsr" to all package names. I would greatly appreciate it if you could review the updates once again and provide any further feedback as needed.

@song-ms song-ms requested a review from cottsay February 27, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants