Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

val3_driver: remove magic numbers #7

Open
gavanderhoorn opened this issue Jul 11, 2016 · 1 comment
Open

val3_driver: remove magic numbers #7

gavanderhoorn opened this issue Jul 11, 2016 · 1 comment
Labels
enhancement New feature or request

Comments

@gavanderhoorn
Copy link
Member

The current staubli_val3_driver VAL3 sources contain quite a few magic numbers (here, here and here for example).

Ideally, these are replaced by proper constants with semantically meaningful names, so as to avoid confusion and potential (future) errors.

Especially those related to simple_message protocol aspects are good candidates for refactoring, as they already have defined names and should be easy to replace. See Defined Constants in Message Structures of the ROS-Industrial Simple Message Protocol (candidate REP) and simple_message/simple_message.h for this.
@gavanderhoorn gavanderhoorn transferred this issue from ros-industrial/staubli_experimental Jan 16, 2020
@marshallpowell97 marshallpowell97 mentioned this issue Jan 21, 2020
Merged
@gavanderhoorn
Copy link
Member Author

#8 will improve the situation, but there will still be a few left (such as in fetchStatus fi).

@gavanderhoorn gavanderhoorn added the enhancement New feature or request label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavanderhoorn