Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAL 3 linter? #10

Open
gavanderhoorn opened this issue Jan 27, 2020 · 10 comments
Open

VAL 3 linter? #10

gavanderhoorn opened this issue Jan 27, 2020 · 10 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gavanderhoorn
Copy link
Member

Just wondering: @marshallpowell97: would you happen to know whether there is a VAL 3 linter available somewhere?

This might be nice to have in the CI setup (#9). But would have to be stand-alone of course (ie: not integrated into SRS).

@gavanderhoorn gavanderhoorn added enhancement New feature or request help wanted Extra attention is needed labels Jan 27, 2020
@gavanderhoorn
Copy link
Member Author

Seeing as it's all XML (at a low-level), we could run a generic XML linter/parser just to see whether files don't contain any illegal entities, etc.

@marshallpowell97
Copy link
Contributor

Just wondering: @marshallpowell97: would you happen to know whether there is a VAL 3 linter available somewhere?

I don't believe so. There is a syntax checker built into SRS, but I am not aware of anything standalone.

@gavanderhoorn
Copy link
Member Author

There is a syntax checker built into SRS

is the VAL 3 grammar available somewhere? Either in documentation or as a file?

What does the SRS use to check the syntax? Perhaps some of that could be reused.

@marshallpowell97
Copy link
Contributor

I did some more digging and I found an "offline syntax checker" that is included with SRS as a .exe file. The documentation is lacking, but does this seem to be what you are looking for?
image

@gavanderhoorn
Copy link
Member Author

Oh, that's a nice find.

Would you happen to know what sort of dependencies it has?

We could potentially integrate it into a Windows based CI setup (using github actions fi).

@gavanderhoorn
Copy link
Member Author

@marshallpowell97: have you been able to find out anything more?

@marshallpowell97
Copy link
Contributor

@gavanderhoorn I can't seem to get it to work. I am trying to find someone at Staubli that knows how to use it.

If you have access to SRS (even without a license), it should already be included.

@gavanderhoorn
Copy link
Member Author

I am trying to find someone at Staubli that knows how to use it.

have you been able to find anyone?

@marshallpowell97
Copy link
Contributor

@gavanderhoorn I was able to get this working. Do you have access to a copy of SRS? Even without a license, you should be able to download and install emulators which include the syntax checker for that specific controller/VAL 3 version.

@gavanderhoorn
Copy link
Member Author

I have some old copies here. I'd have to check whether I could download newer ones.

If not, I'll try to reach out to Staubli Benelux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Development

No branches or pull requests

2 participants