Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children test failing (pt 2) #75

Closed
KaiAragaki opened this issue Apr 1, 2024 · 1 comment
Closed

Children test failing (pt 2) #75

KaiAragaki opened this issue Apr 1, 2024 · 1 comment

Comments

@KaiAragaki
Copy link

Note that this issue is different from #45

It seems like children works for ITIS is failing due to different names being expected and given.

Failing test:

expect_named(res[[1]], c("id", "name", "rank"))

Current output:

res <- children(c(154395, 154357), db="itis")
> res
$`154395`
# A tibble: 8 × 5
  parentname parenttsn rankname taxonname          tsn    
  <chr>      <chr>     <chr>    <chr>              <chr>  
1 Apis       154395    Species  Apis mellifera     154396 
2 Apis       154395    Species  Apis andreniformis 763550 
3 Apis       154395    Species  Apis cerana        763551 
4 Apis       154395    Species  Apis dorsata       763552 
5 Apis       154395    Species  Apis florea        763553 
6 Apis       154395    Species  Apis koschevnikovi 763554 
7 Apis       154395    Species  Apis nigrocincta   763555 
8 Apis       154395    Species  Apis laboriosa     1128092

$`154357`
# A tibble: 1,741 × 5
   parentname   parenttsn rankname taxonname                tsn   
   <chr>        <chr>     <chr>    <chr>                    <chr> 
 1 Lasioglossum 154357    Species  Lasioglossum abanci      757878
 2 Lasioglossum 154357    Species  Lasioglossum aberrans    757879
 3 Lasioglossum 154357    Species  Lasioglossum abietum     757880
 4 Lasioglossum 154357    Species  Lasioglossum ablenum     757881
 5 Lasioglossum 154357    Species  Lasioglossum abrophilum  757882
 6 Lasioglossum 154357    Species  Lasioglossum absimile    757883
 7 Lasioglossum 154357    Species  Lasioglossum absurdiceps 757884
 8 Lasioglossum 154357    Species  Lasioglossum abundum     757885
 9 Lasioglossum 154357    Species  Lasioglossum aburiellum  757886
10 Lasioglossum 154357    Species  Lasioglossum aburiense   757887
# ℹ 1,731 more rows
# ℹ Use `print(n = ...)` to see more rows
r$> packageVersion("taxizedb")
[1] ‘0.3.1
@KaiAragaki
Copy link
Author

I was in error - needed to restart my R session. However, taxize and taxizedb return different names (taxize, which was loaded in my environment, uses the above names; taxizedb uses the ones described in the test)

@KaiAragaki KaiAragaki closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant