diff --git a/DESCRIPTION b/DESCRIPTION index de3bdaf..963653d 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -25,7 +25,7 @@ URL: https://docs.ropensci.org/readODS/, https://github.com/ropensci/readODS BugReports: https://github.com/ropensci/readODS/issues Imports: cellranger, - minty, + minty (>= 0.0.5), stringi, tibble, vctrs (>= 0.4.2), diff --git a/NEWS.md b/NEWS.md index 86bdd5c..c449a3c 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,6 +2,7 @@ * Fix #207, trim off large or unused test files * Fix #209, require R >= 4.0.0 due to `cpp11` +* Fix #211, fix a bug (in minty) for parsing cells with only spaces # readODS 2.3.1 diff --git a/tests/testdata/test_may_make_read_ods_crash_v2.ods b/tests/testdata/test_may_make_read_ods_crash_v2.ods new file mode 100644 index 0000000..f02beee Binary files /dev/null and b/tests/testdata/test_may_make_read_ods_crash_v2.ods differ diff --git a/tests/testthat/test_read_ods.R b/tests/testthat/test_read_ods.R index b917f6a..2d86555 100644 --- a/tests/testthat/test_read_ods.R +++ b/tests/testthat/test_read_ods.R @@ -165,3 +165,7 @@ test_that("Warns of empty sheet", { expect_warning(read_fods("../testdata/empty.fods")) }) }) + +test_that("minty v0.0.5 #211", { + expect_error(read_ods("../testdata/test_may_make_read_ods_crash_v2.ods", trim_ws = TRUE), NA) +})