-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch warnings and messages #212
Comments
We could also do some restructuring here to help the manual scheduler avoid requiring its workers to access the cache. Most of it will be in run.R and build.R. As @krlmlr mentioned, this could help with Digital Ocean-based caches. |
If we do not want remote processes to write to the cache (#236), then we may have to wait for |
Echoing @krlmlr's comment in richfitz/remake#177, a complete solution would have |
More thoughts: warnings and errors would naturally constitute part of the running |
Update: I am optimistic about being able to push a fix today or tomorrow. Rather than jumping to fancy data structures, the expedient thing turned out to be just to add more stuff to the existing metadata. The main change that users will notice is the |
Fixed via #248. Tougher than I expected, but it really helps get the internals ready for the next issues. |
Thanks for looking into it! I'm really eager to try this out, but might take a while. |
Suggested by @krlmlr, also by @fmichonneau in richfitz/remake#177. For
drake
, I think a good solution will:storr
namespaces that help prevent Huge number of files in .drake/keys .drake/data #154.) Errors are processed and cached here. I suspect ordinary exception handling around the call to one_try() would catch warnings.warnings()
aftermake()
.type
argument todiagnose()
that could be"error"
,"warning"
, or"message"
, depending on the kind of build log the user wants. I am open to suggestions for better names.type
could be more specific, anddiagnose()
could be generalized to adrake_build_log()
at that point.Edit: to do:
diagnose()
report errors, warnings, messages, etc.diagnose()
.The text was updated successfully, but these errors were encountered: