Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools::check fails #37

Open
kenarab opened this issue Jan 17, 2020 · 3 comments
Open

devtools::check fails #37

kenarab opened this issue Jan 17, 2020 · 3 comments
Assignees
Milestone

Comments

@kenarab
Copy link
Contributor

kenarab commented Jan 17, 2020

Maybe it has to do with R 3.6.0 standards. We need to solve it for normalizing Travis CI building

> checking Rd cross-references ... WARNING
  Missing link or links in documentation object 'PolyhedronStateDefined.class.Rd':
    ‘[Rpolyhedra:PolyhedronState]{Rpolyhedra::PolyhedronState}’
  
  Missing link or links in documentation object 'PolyhedronStateDeserializer.class.Rd':
    ‘[Rpolyhedra:PolyhedronState]{Rpolyhedra::PolyhedronState}’
  
  Missing link or links in documentation object 'PolyhedronStateDmccooeyScraper.class.Rd':
    ‘[Rpolyhedra:PolyhedronState]{Rpolyhedra::PolyhedronState}’
  
  Missing link or links in documentation object 'PolyhedronStateNetlibScraper.class.Rd':
    ‘[Rpolyhedra:PolyhedronState]{Rpolyhedra::PolyhedronState}’
  
  See section 'Cross-references' in the 'Writing R Extensions' manual.

> checking whether packageRpolyhedracan be installed ... NOTE
  See below...

> checking Rd files ... NOTE
  prepare_Rd: PolyhedraDatabase.class.Rd:12-14: Dropping empty section \details

── Test failures ──────────────────────────────────────────────────────────────────────────────────── testthat ────

> library(Rpolyhedra)
> library(stringr)
> library(futile.logger)
> library(rgl)
> library(geometry)
> library(testthat)
> 
> 
> #Change threshold to ERROR. Comment out/change if verbosity required for development
> futile.logger::flog.threshold(futile.logger::ERROR)
NULL
> 
> #' getDataDirMockedTest mocked function for a temp dest folder for testing proposes
> 
> 
> 
> testthat::test_check("Rpolyhedra")
── 1. Error: create minimal db (@test_db_lib.R#5)  ────────────────────────────────────────────────────────────────
cannot change value of locked binding for '.scrape.config'
Backtrace:
 1. testthat::expect_equal(selectDataEnv("PACKAGE"), "PACKAGE")
 4. Rpolyhedra:::selectDataEnv("PACKAGE")
 5. Rpolyhedra:::updatePolyhedraDatabase()
 6. Rpolyhedra:::setPackageEnvir(".scrape.config", "pkg-minimal")
 7. base::assign(x = variable.name, value = value, envir = asNamespace("Rpolyhedra"))

── 2. Error: test on env lib functions (@test_env_lib.R#20)  ──────────────────────────────────────────────────────
cannot change value of locked binding for '.scrape.config'
Backtrace:
 1. testthat::expect_equal(selectDataEnv(env = "PACKAGE"), "PACKAGE")
 4. Rpolyhedra:::selectDataEnv(env = "PACKAGE")
 5. Rpolyhedra:::updatePolyhedraDatabase()
 6. Rpolyhedra:::setPackageEnvir(".scrape.config", "pkg-minimal")
 7. base::assign(x = variable.name, value = value, envir = asNamespace("Rpolyhedra"))

── 3. Error: test on package lib functions (@test_package_lib.R#16)  ──────────────────────────────────────────────
cannot change value of locked binding for '.scrape.config'
Backtrace:
 1. testthat::expect(!is.null(updatePolyhedraDatabase()), failure_message = "updatePolyhedraDatabase cannot be null")
 2. Rpolyhedra:::updatePolyhedraDatabase()
 3. Rpolyhedra:::setPackageEnvir(".scrape.config", "pkg-minimal")
 4. base::assign(x = variable.name, value = value, envir = asNamespace("Rpolyhedra"))

══ testthat results  ══════════════════════════════════════════════════════════════════════════════════════════════
[ OK: 634 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 3 ]
1. Error: create minimal db (@test_db_lib.R#5) 
2. Error: test on env lib functions (@test_env_lib.R#20) 
3. Error: test on package lib functions (@test_package_lib.R#16) 

Error: testthat unit tests failed
Execution halted

1 error x | 1 warning x | 2 notes x
@kenarab kenarab added this to the v0.4.4 milestone Jan 17, 2020
@sckott
Copy link

sckott commented Dec 9, 2020

👋🏽 We (rOpenSci staff) occasionally go through repositories in our org and try to help out as needed. It seems like your Travis-CI builds https://travis-ci.org/github/ropensci/Rpolyhedra/builds have been failing for a while. In addition, the builds we do across all rOpenSci packages are failing https://github.com/r-universe/ropensci/runs/1134128901?check_suite_focus=true#step:7:17 for macOS. Last, Travis-CI has recently announced a change in their business, so you may want to switch to another CI like github actions or similar

@kenarab
Copy link
Contributor Author

kenarab commented Dec 15, 2020 via email

@sckott
Copy link

sckott commented Dec 15, 2020

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants