Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo] can't upgrade to @yarnpkg/builder@^4.0.0 #2415

Open
3 tasks done
kellymears opened this issue Aug 17, 2023 · 3 comments
Open
3 tasks done

[repo] can't upgrade to @yarnpkg/builder@^4.0.0 #2415

kellymears opened this issue Aug 17, 2023 · 3 comments
Assignees
@kellymears
Labels
blocked

Comments

@kellymears
Copy link
Member

kellymears commented Aug 17, 2023 •
edited
Loading

Agreement

Describe the issue

Repo cli (@bud) is a yarn plugin but the build fails using version 4.0.0 of @yarnpkg/builder.

Expected Behavior

After installing @yarnpkg/[email protected] running yarn install will build the @bud cli

Actual Behavior

The @bud cli build process fails.

Steps To Reproduce

  1. Run yarn upgrade-interactive.
  2. Select @yarnpkg/builder (4.0.0-rc-46 -> 4.0.0)

version

0.0.0

Logs

Usage Error: This plugin cannot access the package referenced via node:fs which is neither a builtin, nor an exposed entry (when initializing @yarnpkg/plugin-bud, defined in /Users/kellymears/code/git/roots/bud/.yarnrc.yml)

Configuration

No response

Relevant .budfiles

No response
@kellymears kellymears self-assigned this Aug 17, 2023
@kellymears
Copy link
Member Author

If I replace the node:* with the non namespaced equivalents manually, it works. I think @yarnpkg/builder might need to include node:* as externals.

This was referenced Aug 17, 2023
Closed
Merged
kodiakhq bot pushed a commit that referenced this issue Aug 17, 2023
@kellymears
⚙️ internal(none): patch @yarnpkg/builder (#2418)
fe49c8a 
Patches `@yarnpkg/builder` to strip `node:` from `node:*` imports.

Closes: 
- #2415

Ref:
- #2352

## Type of change

**NONE: internal change**
@kellymears
Copy link
Member Author

I patched it with an esbuild plugin, which should do for now.

@kellymears kellymears mentioned this issue Dec 17, 2023
Merged
kodiakhq bot pushed a commit that referenced this issue Dec 17, 2023
@kellymears
📦 deps(none): patch @yarnpkg/builder@npm:4.0.0 (#2527)
eea317a 
- patch `@yarnpkg/builder@npm:4.0.0` to account for `node:*` built-ins.

## References

- #2415 

## Type of change

**PATCH: backwards compatible change**
@kellymears
Copy link
Member Author

Updated the patch in #2527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kellymears kellymears

Labels
blocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kellymears