Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the RDataFrame JIT logic to avoid controlled leaks #15520

Open
vepadulano opened this issue May 15, 2024 · 0 comments
Open

Rewrite the RDataFrame JIT logic to avoid controlled leaks #15520

vepadulano opened this issue May 15, 2024 · 0 comments

Comments

@vepadulano
Copy link
Member

Explain what you would like to see improved and how.

The RDataFrame JIT logic makes use of a series of controlled memory leaks between different functions to ensure lifetime of objects that are needed by the JIT until that actually happens.

This is an optimization but has certain fragilities, that were already analysed in a recent bug report. The same topic surfaced in the past (see this issue moved from JIRA). And the fact we rely on leaking objects is subtly error-prone (see a recent PR).

We should investigate how to implement a different way to handle the JIT machinery so that it does not require leaking objects.

ROOT version

Any

Installation method

Any

Operating system

Any

Additional context

No response

@vepadulano vepadulano self-assigned this May 15, 2024
@dpiparo dpiparo changed the title Rewrite the JIT logic to avoid controlled leaks Rewrite the RDataFrame JIT logic to avoid controlled leaks May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant