Skip to content

Commit 1fdb82c

Browse files
committed
[compat] mark failing specs as pending for now
1 parent 1196f26 commit 1fdb82c

File tree

8 files changed

+31
-1
lines changed

8 files changed

+31
-1
lines changed

spec/integration/associations/many_to_many/from_view_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@
7878
end
7979

8080
it "prepares joined relations using custom FK" do
81+
pending_if_compat_mode
82+
8183
relation = assoc.().order(puzzles[:text].qualified, puzzle_solvers[:user_id].qualified)
8284

8385
expect(relation.schema.map(&:to_sql_name))

spec/integration/associations/many_to_one/from_view_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@
7272
end
7373

7474
it "prepares joined relations using custom view in target relation" do
75+
pending_if_compat_mode
76+
7577
relation = assoc_inter.()
7678

7779
expect(relation.schema.map(&:to_sql_name))

spec/integration/associations/one_to_many/from_view_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@
5050
end
5151

5252
it "prepares joined relations using custom view" do
53+
pending_if_compat_mode
54+
5355
relation = assoc.()
5456

5557
expect(relation.schema.map(&:to_sql_name))

spec/integration/auto_migrations/file_based_migrations_spec.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ def migrations
3939
end
4040

4141
it "creates migration files by schema definitions" do
42+
pending_if_compat_mode
43+
4244
gateway.auto_migrate!(conf, options)
4345
expect(migrations.size).to eql(1)
4446

@@ -83,6 +85,8 @@ def migrations
8385
end
8486

8587
it "creates migration files by schema definitions" do
88+
pending_if_compat_mode
89+
8690
gateway.auto_migrate!(conf, options)
8791
expect(migrations.size).to eql(1)
8892

spec/integration/auto_migrations/indexes_spec.rb

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ def indexdef(index)
4545
end
4646

4747
it "creates ordinary b-tree indexes" do
48+
pending_if_compat_mode
49+
4850
gateway.auto_migrate!(conf, inline: true)
4951

5052
expect(attributes.map(&:to_ast))
@@ -98,6 +100,8 @@ def indexdef(index)
98100
end
99101

100102
it "supports custom names" do
103+
pending_if_compat_mode
104+
101105
conn.create_table :users do
102106
primary_key :id
103107
end
@@ -124,6 +128,8 @@ def indexdef(index)
124128
end
125129

126130
it "adds index to existing column" do
131+
pending_if_compat_mode
132+
127133
conn.create_table :users do
128134
primary_key :id
129135
column :name, String
@@ -150,6 +156,8 @@ def indexdef(index)
150156
end
151157

152158
it "supports unique indexes" do
159+
pending_if_compat_mode
160+
153161
conn.create_table :users do
154162
primary_key :id
155163
column :name, String
@@ -177,6 +185,8 @@ def indexdef(index)
177185

178186
if metadata[:postgres]
179187
it "uses index method" do
188+
pending_if_compat_mode
189+
180190
conn.create_table :users do
181191
primary_key :id
182192
column :props, :jsonb, null: false
@@ -200,6 +210,8 @@ def indexdef(index)
200210
end
201211

202212
it "supports partial indexes" do
213+
pending_if_compat_mode
214+
203215
conn.create_table :users do
204216
primary_key :id
205217
column :name, String

spec/integration/plugins/auto_restrictions_spec.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ class Test::Tasks < ROM::Relation[:sql]
7070

7171
include_context "auto-generated restriction view"
7272

73-
it "generates restrictrions by a composite index" do
73+
it "generates restrictions by a composite index" do
74+
pending_if_compat_mode
75+
7476
expect(tasks.by_user_id_and_title(1, "Jane's task").first).to eql(id: 2, user_id: 1, title: "Jane's task")
7577
end
7678
end

spec/integration/schema/view_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
end
2424

2525
it "automatically projects a relation view" do
26+
pending_if_compat_mode
27+
2628
expect(relations[:users].names.to_a)
2729
.to eql([{name: "Jade"}, {name: "Jane"}, {name: "Joe"}])
2830
end

spec/support/env_helper.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,8 @@ def oracle?(example)
2424
def jruby?
2525
defined? JRUBY_VERSION
2626
end
27+
28+
def pending_if_compat_mode
29+
pending "FIXME: not working in compat mode yet" if ENV["ROM_COMPAT"] == "true"
30+
end
2731
end

0 commit comments

Comments
 (0)