Skip to content

Commit 86f6d41

Browse files
authored
Fixed tested and fixed html examples with no build system (#1261)
1 parent 7d1d90d commit 86f6d41

File tree

7 files changed

+10
-11
lines changed

7 files changed

+10
-11
lines changed

bower.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"dependencies": {},
44
"main": ["dist/rollbar.umd.js"],
55
"ignore": [
6-
"dist/*.nojson*",
76
"dist/*.named-amd*",
87
"docs",
98
"src",

examples/bower/bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
"version": "0.0.1",
44
"homepage": "https://github.com/rollbar/rollbar.js",
55
"dependencies": {
6-
"rollbar": "~1.7.0"
6+
"rollbar": "^2.26.4"
77
}
88
}

examples/include_custom_object.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818
// as an example, let's include the current value of window.myvariable
1919
// as custom data in the payload.
2020

21-
// ensure payload.data.custom is set
22-
payload.data.custom = payload.data.custom || {};
21+
// ensure payload.custom is set
22+
payload.custom = payload.custom || {};
2323

2424
// add our data
25-
payload.data.custom.myvariable = window.myvariable;
25+
payload.custom.myvariable = window.myvariable;
2626

2727
// no need to return anything (return value is unused)
2828
};

examples/requirejs/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
```js
66
//
7-
// Download the latest rollbar.umd.nojson.min.js and place in current directory.
7+
// Download the latest rollbar.min.js and place in current directory.
88
var rollbarConfig = {
99
accessToken: '...',
1010
captureUncaught: true,
@@ -14,7 +14,7 @@ var rollbarConfig = {
1414
};
1515

1616
// Require the Rollbar library
17-
require(['rollbar.umd.nojson.min.js'], function (Rollbar) {
17+
require(['rollbar.umd.min'], function (Rollbar) {
1818
var rollbar = Rollbar.init(rollbarConfig);
1919
rollbar.info('Hello world');
2020
});

examples/requirejs/test.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<script>
66
var _rollbarConfig = {
77
accessToken: 'POST_CLIENT_ITEM_ACCESS_TOKEN',
8-
rollbarJsUrl: '../../dist/rollbar.umd.js',
8+
rollbarJsUrl: '../../dist/rollbar.umd.min',
99
captureUncaught: true,
1010
payload: {
1111
environment: 'development',
@@ -18,7 +18,7 @@
1818
// NOTE: you must use the name "rollbar" here.
1919
require.config({
2020
paths: {
21-
rollbar: '../../dist/rollbar.umd',
21+
rollbar: '../../dist/rollbar.umd.min',
2222
},
2323
});
2424

examples/snippet.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
payload: {
99
environment: 'test',
1010
},
11-
rollbarJsUrl: 'http://localhost:8080/dist/rollbar.js',
11+
rollbarJsUrl: '/dist/rollbar.js',
1212
};
1313
</script>
1414
<script>

examples/test.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
var _rollbarConfig = {
2525
accessToken: '12c99de67a444c229fca100e0967486f',
26-
rollbarJsUrl: '/dist/rollbar.umd.nojson.js',
26+
rollbarJsUrl: '/dist/rollbar.umd.js',
2727
captureUncaught: true,
2828
//checkIgnore: ignoreFilesUncaught,
2929
payload: {

0 commit comments

Comments
 (0)