Upgrade V8 binaries for 10.9.194.9 version **working** (#363)

* Upgrade V8 binaries for 10.9.194.9 version

* Fixes to support newest stable v8.

- Update github workflow to use go 18 & 19
- Update github workflow to use macos-latest
- Update github build workflow to use ubuntu 22.04
- Add gitignore for jetbrains and .gclient_previous files
- Switch cgo build to C++17 and enable sandbox at build time
- Update test with update to date error message
- Remove no longer supported build flag.
- Move initialization to v8go.go and include flag set to avoid flag freezing
- Reorder initialization so allocator is initialized after v8 (required by latest v8)

* Update V8 static library for macos-11 x86_64

* Update V8 static library for ubuntu-22.04 x86_64

* Update V8 static library for macos-11 arm64

* Update V8 static library for ubuntu-22.04 arm64

* Update changelog and remove no-longer valid comment

---------

Co-authored-by: jacques-n <[email protected]>

Author: jacques-n

.github/workflows/test.yml

@@ -12,11 +12,8 @@ jobs:
     name: Tests on ${{ matrix.go-version }} ${{ matrix.platform }}
     strategy:
       matrix:
-        go-version: [1.16.8, 1.17.1]
-        # We use macos-11 over macos-latest because macos-latest defaults to Catalina(10.15) and not Big Sur(11.0)
-        # We can switch to macos-latest whenever Big Sur becomes the default
-        # See https://github.com/actions/virtual-environments#available-environments
-        platform: [ubuntu-latest, macos-11]
+        go-version: [1.18.10, 1.19.5]
+        platform: [ubuntu-latest, macos-latest]
     runs-on: ${{ matrix.platform }}
 
     steps:

.github/workflows/v8build.yml

@@ -14,7 +14,7 @@ jobs:
                 #
                 # We need xcode 12.4 or newer to cross compile between arm64/amd64
                 # https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#xcode
-                platform: [ubuntu-18.04, macos-11]
+                platform: [ubuntu-22.04, macos-11]
                 arch: [x86_64, arm64]
         runs-on: ${{ matrix.platform }}
         steps:
@@ -27,10 +27,10 @@ jobs:
               run: cd deps/depot_tools && git config --unset-all remote.origin.fetch; git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/*
               shell: bash
             - name: Install g++-aarch64-linux-gnu
-              if: matrix.platform == 'ubuntu-18.04' && matrix.arch == 'arm64'
+              if: matrix.platform == 'ubuntu-22.04' && matrix.arch == 'arm64'
               run: sudo apt update && sudo apt install g++-aarch64-linux-gnu -y
             - name: Build V8 linux
-              if: matrix.platform == 'ubuntu-18.04'
+              if: matrix.platform == 'ubuntu-22.04'
               run: cd deps && ./build.py --no-clang --arch ${{ matrix.arch }}
             - name: Build V8 macOS
               if: matrix.platform == 'macos-11'

.gitignore

@@ -6,7 +6,7 @@
 .gclient_entries
 
 deps/darwin-x86_64/libv8_debug.a
-
+deps/.gclient_previous*
 c.out
-
+.idea/*
 /v8go.test

CHANGELOG.md

@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - Use string length to ensure null character-containing strings in Go/JS are not terminated early.
 - Object.Set with an empty key string is now supported
+- Upgrade to V8 10.9.194.9
+- Upgrade V8 build OS to Ubuntu 22.04
 
 ## [v0.7.0] - 2021-12-09
 

cgo.go

@@ -6,7 +6,7 @@ package v8go
 
 //go:generate clang-format -i --verbose -style=Chromium v8go.h v8go.cc
 
-// #cgo CXXFLAGS: -fno-rtti -fPIC -std=c++14 -DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -I${SRCDIR}/deps/include -Wall
+// #cgo CXXFLAGS: -fno-rtti -fPIC -std=c++17 -DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -I${SRCDIR}/deps/include -Wall -DV8_ENABLE_SANDBOX
 // #cgo LDFLAGS: -pthread -lv8
 // #cgo darwin,amd64 LDFLAGS: -L${SRCDIR}/deps/darwin_x86_64
 // #cgo darwin,arm64 LDFLAGS: -L${SRCDIR}/deps/darwin_arm64