-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NFL scoring information to Boxscore #759
Comments
This is a cool idea. One consideration you might want to make, is dumping the dictionary into a stringified JSON and including it as a field in the output dataframe. That said, this repo appears to be abandoned by the admin. I have a fork that I'm using for my own purposes and I'm in the process of updating the codebase to accomodate several changes that have been made to the website that have broken some features. If you implement this change you might be better off forking it yourself. But I'm interested in seeing your changes when you make them and I'd be happy to collaborate. |
I'm in the process of adding an option to NFL Boxscore to get all the scoring possession details from the game, as shown on the Sports Reference website, and would like to get input on the feature before I create a pull request. Following is the general documentation for the feature:
Returns a "list" containing a list for each quarter's scores. Each score is represented by a "dictionary" that holds the following keys:
For example:
Example for <1st-quarter-scores>:
The text was updated successfully, but these errors were encountered: