Might it make sense to contribute this reporter to buildbot core?

[terencehonles]

It looks like there were a number of stabs at adding Slack reporters to buildbot, but they stalled on making sure they had testing. Would it make sense to contribute this reporter to buildbot core?

One feature that would probably helpful (at least for me) is to allow this reporter to respect builder tags, and that might be appropriate to do when updating for #13

[rockwelln]

hello @terencehonles, indeed I was surprised to find Slack not supported out-of-the-box.

Would it make sense to contribute this reporter to buildbot core?

probably. but I don't know if buildbot core maintainers want to support new reporters. Anyway, I would be glad to contribute it to the core itself.

One feature that would probably helpful (at least for me) is to allow this reporter to respect builder tags, and that might be appropriate to do when updating for #13

ok. I can't guarantee you it will be there when #13 will be fixed, but I'll have a look ;-)

[terencehonles]

I have a feeling they might, the reason I was asking about contributing was I wasn't sure if you cared or wanted to merge the code in and I couldn't copy the code in without asking for permission. If you would like to potentially propose the PR, I can manage updating it as needed in order to help get it merged in (or support in any other way I can).

[zplizzi]

I would also love to see this contributed to buildbot core and opened an issue in their repo so it's tracked on both ends.

[p12tic]

Hi, I'm one of the maintainers of Buildbot. It would be great to have this in the upstream Buildbot. The only significant thing that would be needed in addition to the current code is tests, but they are relatively easy to write as we already have all the infrastructure for capturing outgoing HTTP requests and comparing them to some known good value.

[terencehonles]

I don't mind doing ^^^ since I would like to have slack notifications in buildbot, but this has stalled because I didn't feel like I got permission to copy the code at least after "asking" here #14 (comment), but re-reading it does look like this is probably sufficient:

probably. but I don't know if buildbot core maintainers want to support new reporters. Anyway, I would be glad to contribute it to the core itself.

I'll try to carve out some time to create a PR, but if someone else can get to it before me feel free to start and tag me in the PR and I can help there.