-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poor errors for invalid pusher return type #1028
Labels
Future
Something we want to fix but is not blocking next release
Comments
This is once again our assertion functions not printing context aware errors. |
Is there a general pattern we can look for in the codebase to find all of
these at once?
On Sun, Oct 16, 2022 at 10:27 PM Erik Arvidsson ***@***.***> wrote:
This is once again our assertion functions not printing context aware
errors.
—
Reply to this email directly, view it on GitHub
<#1028 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATUBGSDK35EKBSHHCXOZLWDUEYRANCNFSM6AAAAAARGPFYNA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
a (phone)
|
Yes. These function all look like: export function assertIndexDefinitions(
value: unknown,
): asserts value is IndexDefinitions {
...
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See: https://discord.com/channels/830183651022471199/830183651022471202/1031283567906541642
I used a debug build to see that error was actually:
We need to handle these errors better and print a more comprehensible error message. Check puller too.
See also: #575. Perhaps should do at same time.
The text was updated successfully, but these errors were encountered: