Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance to apply those changes? #337

Open
Najafov007 opened this issue Sep 17, 2024 · 3 comments
Open

Any chance to apply those changes? #337

Najafov007 opened this issue Sep 17, 2024 · 3 comments

Comments

@Najafov007
Copy link

Hello! Thank you for your app, it's amazing! However, we do have some sort of an issue. We have our own cluster that runs approximately 1k pods on it. The thing is besides the report itself, is there any chance to apply those changes? Like its impossible to do it manually, isn't it? For example we use kustomize on our services and GitOps philosophy. How can we for example make it automatically apply those changes on a new branch? Would be amazing. Thank you

@aantn
Copy link
Contributor

aantn commented Sep 17, 2024

Hi, we don't have the option available but of course PRs are welcome! You could create a custom outputer that generates kustomize overlays, for example.

@wrbbz
Copy link

wrbbz commented Feb 27, 2025

That's a nice feature to have.
We also got a lot of pods. It's nice to have some analytics from the tool, but it's very unpleasant to tweak resources manually.

I thought about automatic PRs with resource changes. Some of which could be automerged. But for that thing, you have to know in which file to change resource. For that you have to have some kind of configuration file, which you need to parse. And implement a ton of logic for interaction with Git(Hub|Lab) API. and that logic will be out of scope of this tool

Another option - to apply suggestions on the fly. And somehow monitor diff between source code and actual resource. However, I suppose, you do not want to apply all suggestions (at least, I do not). It would be perfect to select which suggestions to apply. And thus, you also will need some kind of configuration

Both approaches require a ton of time and effort as I think

@aantn
Copy link
Contributor

aantn commented Mar 1, 2025

Yep! @Avi-Robusta from the Robusta team actually has a working PR that uses LLMs to figure out which file to change, and use the GitHub APIs to open a PR. (It is indeed a little out of scope for KRR - he's doing it with our other OSS project https://github.com/robusta-dev/holmesgpt/)

Let me know if you're interested in trying it out and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants