Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods are not found #139

Open
alexanderniebuhr opened this issue Aug 31, 2023 · 10 comments
Open

Pods are not found #139

alexanderniebuhr opened this issue Aug 31, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@alexanderniebuhr
Copy link

alexanderniebuhr commented Aug 31, 2023

Describe the bug
We do have Pods which are created by another Pod (GitLab Runner Kubernetes Executer).
These Pods don't have a Deployment, but even while they are running, they are not found in krr.

How can these Pods also be checked.

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot 2023-08-31 at 21 18 40

@obrienrobert
Copy link

I have a similar issue where pods are controlled by a service as opposed to a Deployment/StatefulSet/DaemonSet etc. It would be great if such pods could also be included in the result set.

@LeaveMyYard
Copy link
Contributor

Hey! So, when starting this project we descided to skip recommendations for standalone pods
But if you guys ask, I think this is time to add this feature

@LeaveMyYard LeaveMyYard self-assigned this Sep 1, 2023
@LeaveMyYard LeaveMyYard added the enhancement New feature or request label Sep 1, 2023
@alexanderniebuhr
Copy link
Author

We are also missing CronJob & Job

@LeaveMyYard
Copy link
Contributor

@alexanderniebuhr Jobs should work as expected, but CronJobs we haven't added also
Will add those for future tasks

@mrclrchtr
Copy link

Thank you so much for this fantastic tool!

I was wondering today why the github runner wasn't showing up and then found this issue. This is probably related to that right?

@aantn
Copy link
Contributor

aantn commented Aug 15, 2024

@mrclrchtr can you try running krr with the prometheus-workload-loader branch and see if they show up there?

@mrclrchtr
Copy link

I tried the prometheus-workload-loader branch and unfortunately it doesn't show up.

@lictw
Copy link

lictw commented Sep 12, 2024

The LimitRange is other case, so the deployments aren't have Resources values and leave them to shared/common values in LimitRange, but pods have requests and krr does not consider it. View with pods should help.

@hanleybrand
Copy link

hanleybrand commented Jan 16, 2025

I'm having a similar problem -- I ran krr on an airflow cluster, but only got back the pods that are in deployments, not the pods running the workflows which are standalone pods.

I can get currently running worker pods using
kubectl get pods -n airflow --selector 'component in (worker)'

NAME READY STATUS RESTARTS AGE
dap-init-or-sync-db-auff9ubk 1/1 Running 0 3m13s

but running
krr simple --cluster -n airflow --selector 'component in (worker)'
returns No objects available to scan.

@aantn
Copy link
Contributor

aantn commented Jan 16, 2025

@hanleybrand just to confirm, are they also missing on the prometheus-workload-loader branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants