Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When setting the locales-dir as a param, it is ignored when already specified in the .locorc.json config file #28

Open
eliaslecomte opened this issue May 15, 2023 · 1 comment

Comments

@eliaslecomte
Copy link

If you have the localesDir set in your locorc.json file, and also set it via a CLI flag (-d, --locales-dir <path>), the localesDir from the config file takes precedency, while I would have expected the CLI flag.

@VNDRN
Copy link
Contributor

VNDRN commented Sep 9, 2024

As the CLI adds defaults eg: localesDir: ".", it makes more sense that the config file is the overwriting truth, no?
If we do want the CLI to overwrite the config file, we'd need to extract these defaults from cli.ts and add them in the options.ts. It's possible, but do we want to do that? @robrechtme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants