Skip to content

Add MuJoCo Humanoid MJCF description (and deepmind/mujoco to repository list) #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ManifoldFR
Copy link
Contributor

@ManifoldFR ManifoldFR commented Jul 15, 2025

cdw_screenshot 2025-07-15 14-57-04 +0200

@ManifoldFR ManifoldFR force-pushed the manifoldfr/add-mj-humanoid branch from 0495839 to d825599 Compare July 15, 2025 12:54
@coveralls
Copy link

coveralls commented Jul 15, 2025

Pull Request Test Coverage Report for Build 16294000035

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 98.105%

Totals Coverage Status
Change from base Build 16225601439: 0.009%
Covered Lines: 1191
Relevant Lines: 1214

💛 - Coveralls

Copy link
Member

@stephane-caron stephane-caron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this MJCF description 👍

There is one linter error:

   +++ /home/runner/work/robot_descriptions.py/robot_descriptions.py/robot_descriptions/_repositories.py	2025-07-15 12:57:06.084350+00:00
  @@ -204,11 +204,11 @@
           cache_path="mujoco_menagerie",
       ),
       "mujoco": Repository(
           url="https://github.com/google-deepmind/mujoco.git",
           commit="ad0dc0de5e10a075a2c65be629e9a8d557d383a6",
  -        cache_path="mujoco"
  +        cache_path="mujoco",
       ),
       "nao_robot": Repository(
           url="https://github.com/ros-naoqi/nao_robot.git",
           commit="67476469a1371b00b17538eb6ea336367ece7d44",
           cache_path="nao_robot",
  would reformat /home/runner/work/robot_descriptions.py/robot_descriptions.py/robot_descriptions/_repositories.py

@ManifoldFR ManifoldFR force-pushed the manifoldfr/add-mj-humanoid branch from 9c17315 to 2ffbf27 Compare July 15, 2025 13:01
@stephane-caron stephane-caron merged commit 60f7b15 into robot-descriptions:main Jul 15, 2025
15 checks passed
@ManifoldFR ManifoldFR deleted the manifoldfr/add-mj-humanoid branch July 15, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants