libpressio version 0.50.5

Bug Fixes:

+ span now does not use reserved name _Offset
+ pressio_data now checks if the buffer is empty before calling malloc
  to prevent undefined behavior on platforms where malloc(0) is
  undefined behavior
+ pressio_metrics now handles self assignment
+ bit grooming now uses the correct BG_DOUBLE type for doubles
+ prevent catastrophic truncation in kl_divergance plugin

Author: robertu94

CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.13 FATAL_ERROR)
-project(libpressio VERSION "0.50.4" LANGUAGES CXX C)
+project(libpressio VERSION "0.50.5" LANGUAGES CXX C)
 
 #correct was to set a default build type
 # https://blog.kitware.com/cmake-and-the-default-build-type/

include/libpressio_ext/compat/span.h

@@ -233,15 +233,15 @@ class  span {
         return {data() + size() - count, count};
     }
 
-    template <size_t _Offset, size_t Count = compat_dynamic_extent>
+    template <size_t Offset, size_t Count = compat_dynamic_extent>
 
     constexpr auto subspan() const noexcept
-        -> span<element_type, Count != compat_dynamic_extent ? Count : Extent - _Offset>
+        -> span<element_type, Count != compat_dynamic_extent ? Count : Extent - Offset>
     {
 #if __cplusplus >= 201703L
-        static_assert(_Offset <= Extent, "Offset out of range in span::subspan()");
+        static_assert(Offset <= Extent, "Offset out of range in span::subspan()");
 #endif
-        return {data() + _Offset, Count == compat_dynamic_extent ? size() - _Offset : Count};
+        return {data() + Offset, Count == compat_dynamic_extent ? size() - Offset : Count};
     }
 
 
@@ -419,15 +419,15 @@ class  span<Type, compat_dynamic_extent> {
         return {data() + size() - count, count};
     }
 
-    template <size_t _Offset, size_t Count = compat_dynamic_extent>
+    template <size_t Offset, size_t Count = compat_dynamic_extent>
 
     constexpr span<Type, compat_dynamic_extent> subspan() const noexcept
     {
 #if __cplusplus >= 201703L
-        assert(_Offset <= size() && "Offset out of range in span::subspan()");
-        assert(Count == compat_dynamic_extent || _Offset + Count <= size() && "Count out of range in span::subspan()");
+        assert(Offset <= size() && "Offset out of range in span::subspan()");
+        assert(Count == compat_dynamic_extent || Offset + Count <= size() && "Count out of range in span::subspan()");
 #endif
-        return {data() + _Offset, Count == compat_dynamic_extent ? size() - _Offset : Count};
+        return {data() + Offset, Count == compat_dynamic_extent ? size() - Offset : Count};
     }
 
     constexpr span<element_type, compat_dynamic_extent>

include/libpressio_ext/cpp/data.h

@@ -313,7 +313,7 @@ struct pressio_data {
    * \returns true if the structure has has data
    */
   bool has_data() const {
-    return data_ptr != nullptr;
+    return data_ptr != nullptr && size_in_bytes() > 0;
   }
 
   /**

include/libpressio_ext/cpp/metrics.h

@@ -153,6 +153,7 @@ struct pressio_metrics {
    * move assigns a metric from another pointer
    */
   pressio_metrics& operator=(pressio_metrics const& metrics) {
+    if(&metrics == this) return *this;
     plugin = metrics->clone();
     return *this;
   }

src/plugins/compressors/bit_groooming_plugin.cc

@@ -170,7 +170,7 @@ class bit_grooming_plugin: public libpressio_compressor_plugin {
       }
       else if(type == pressio_double_dtype)
       {
-        return BG_FLOAT;
+        return BG_DOUBLE;
       }
       else
       {

src/plugins/metrics/kl_divergance.cc

@@ -33,8 +33,8 @@ namespace kl_divergence{
       std::for_each( decomp_begin, decomp_end, [&q_counts,&X](value_type q) { q_counts[q] += 1; X.insert(q);});
 
       for (auto const& x : X) {
-        m.p_q += p_counts[x] / p_size * std::log((p_counts[x] * q_size)/ (q_counts[x]* p_size));
-        m.q_p += q_counts[x] / q_size * std::log((q_counts[x] * p_size)/ (p_counts[x]* q_size));
+        m.p_q += static_cast<double>(p_counts[x]) / static_cast<double>(p_size) * std::log((p_counts[x] * q_size)/ (static_cast<double>(q_counts[x])* p_size));
+        m.q_p += static_cast<double>(q_counts[x]) / static_cast<double>(q_size) * std::log((q_counts[x] * p_size)/ (static_cast<double>(p_counts[x])* q_size));
 
       }
 

src/pressio_data.cc

@@ -200,7 +200,11 @@ namespace {
       compat::exclusive_scan(compat::rbegin(iter_max), compat::rend(iter_max), compat::rbegin(strides), 1, compat::multiplies<>{});
       for (size_t src_idx = 0; src_idx < max_idx; ++src_idx) {
         size_t dst_idx = compat::transform_reduce(std::begin(iter), std::end(iter), std::begin(strides), 0, compat::plus<>{}, compat::multiplies<>{});
-        r2_begin[src_idx] = r1_begin[dst_idx];
+        //clang-tidy treats this line as bugprone conversion since
+        //it can cause unintended behavior in switch-case statements 
+        //matching against character codes.  Since we aren't doing
+        //that here, ignore this warning.
+        r2_begin[src_idx] = r1_begin[dst_idx]; //NOLINT
 
         size_t idx = 0;
         bool updating = true;