libpressio version 0.46.1

Bug Fixes

+ Fix several build failures on GCC-4.8 and add CI to ensure they don't
  return.

Author: robertu94

.travis.yml

@@ -6,10 +6,28 @@ matrix:
       env:
         - CC=gcc-7
         - CXX=g++-7
+        - EXTRA_BUILD_ARGS=
+    - os: linux
+      env:
+        - CC=gcc-4.8
+        - CXX=g++-4.8
+        - EXTRA_BUILD_ARGS=-DLIBPRESSIO_CXX_VERSION=11
+      addons:
+        apt:
+          packages:
+            - gcc-4.8
+            - g++-4.8
+            - libboost-dev
+            - doxygen
+            - graphviz
+            - libhdf5-dev
+            - libmagick++-dev
+            - libblosc-dev
     - os: linux
       env:
         - CC=clang
         - CXX=clang++
+        - EXTRA_BUILD_ARGS=
 
 addons:
   apt:
@@ -29,7 +47,7 @@ before_install:
 script:
   - mkdir build
   - cd build
-  - cmake .. -DCMAKE_BUILD_TYPE=Release -DLIBPRESSIO_HAS_SZ=OFF -DLIBPRESSIO_HAS_ZFP=OFF -DBUILD_DOCS=ON
+  - cmake .. -DCMAKE_BUILD_TYPE=Release -DLIBPRESSIO_HAS_SZ=OFF -DBUILD_DOCS=ON $EXTRA_BUILD_ARGS
   - cmake --build .
   - cmake --build . --target docs
   - ctest

CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.13 FATAL_ERROR)
-project(libpressio VERSION "0.46.0" LANGUAGES CXX C)
+project(libpressio VERSION "0.46.1" LANGUAGES CXX C)
 
 #correct was to set a default build type
 # https://blog.kitware.com/cmake-and-the-default-build-type/
@@ -66,6 +66,7 @@ check_cpp_standard(void_t)
 check_cpp_standard(negation)
 check_cpp_standard(clamp)
 check_cpp_standard(string_view)
+check_cpp_standard(is_null_pointer)
 
 
 set(LIBPRESSIO_FEATURES "")
@@ -87,6 +88,7 @@ add_library(libpressio
 
   #compat implementation
   ./src/compat/span.cc
+  ./src/compat/optional.cc
 
   #plugins
   ./src/plugins/compressors/compressor_base.cc

checks/is_null_pointer.cc

@@ -0,0 +1,6 @@
+#include <type_traits>
+
+int main()
+{
+  return std::is_null_pointer<std::nullptr_t>::value;
+}

include/libpressio_ext/compat/algorithm.h

@@ -47,7 +47,9 @@ namespace compat {
 template<class T>
 constexpr const T& clamp( const T& v, const T& low, const T& hi )
 {
+#if __cplusplus >= 201703L
     assert( !(hi < low) );
+#endif
     return (v < low) ? low : (hi < v) ? hi : v;
 }
 
@@ -61,7 +63,9 @@ constexpr const T& clamp( const T& v, const T& low, const T& hi )
 template<class T, class Compare>
 constexpr const T& clamp( const T& v, const T& low, const T& high, Compare comp )
 {
+#if __cplusplus >= 201703L
     assert( !comp(high, low) );
+#endif
     return comp(v, low) ? low : comp(high, v) ? high : v;
 }
 #else

include/libpressio_ext/compat/language.h

@@ -0,0 +1,9 @@
+#include <utility>
+
+#if __cplusplus >= 201703L
+#define  RVO_MOVE(x) (x)
+#define  DEFAULTED_NOEXCEPT noexcept
+#else
+#define  RVO_MOVE(x) std::move(x)
+#define  DEFAULTED_NOEXCEPT
+#endif

include/libpressio_ext/compat/numeric.h

@@ -5,11 +5,11 @@
 #ifndef LIBPRESSIO_COMPAT_NUMERIC_H
 #define LIBPRESSIO_COMPAT_NUMERIC_H
 #include <pressio_version.h>
-#include <type_traits>
 #include <limits>
 #include <cstddef>
 #include <numeric>
 #include "functional.h"
+#include "type_traits.h"
 
 namespace compat {
 #if !(LIBPRESSIO_COMPAT_HAS_MIDPOINT)
@@ -22,11 +22,11 @@ namespace compat {
 template <class Type>
 constexpr typename std::enable_if<std::is_integral<Type>::value &&
                                     !std::is_same<bool, Type>::value &&
-                                    !std::is_null_pointer<Type>::value,
+                                    !compat::is_null_pointer<Type>::value,
                                   Type>::type
 midpoint(Type a, Type b) noexcept
 {
-  using Up = std::make_unsigned_t<Type>;
+  using Up = typename std::make_unsigned<Type>::type;
   constexpr Up bitshift = std::numeric_limits<Up>::digits - 1;
 
   Up diff = Up(b) - Up(a);

include/libpressio_ext/compat/optional.h

@@ -9,13 +9,15 @@
 
 #if !(LIBPRESSIO_COMPAT_HAS_OPTIONAL)
 #include <boost/optional.hpp>
+#include <boost/none.hpp>
 #else
 #include <optional>
 #endif
 
 namespace compat {
 #if (!LIBPRESSIO_COMPAT_HAS_OPTIONAL)
   using boost::optional;
+  extern const boost::none_t& nullopt;
 #else
   using std::optional;
   using std::nullopt;