-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compatible with IGListKit #6
Comments
@otymartin |
@alessandro-martin Thanks for the intel :) |
Hi @alessandro-martin and @otymartin! I'm looking into this. |
I tried to make it work with IGListKit there are some problems : updating an object doesn't refresh its cell, nor change its bounds. It even create a strange gap later in the collectionView that is equal to what the clicked cell should have expanded in height.
Not sure if this is because of BouncyLayout or IGListKit, but it works with a normal Please find attach the example I worked on : |
I progressed a bit, I found a way to do it but it's a bit dirty (see delegate method New code : |
@LivioGama hey so I just tried this. it appears to work nicely except, I lost my grid view. How can I solve that? Could you perhaps subclass ListCollectionViewLayout instead? |
@LivioGama hey dont mean to nudge but still think you can hammer this out, would absolutley love to implement this in my production app🙏 |
It won't work because IGListKit layout is not a Flow layout like BouncyLayout. Maybe Instagram can make a FlowLayout, or maybe the author of BouncyLayout can make a subclass from IGListCollectionViewLayout to try to make that work. Meantime, I'm not expert enough with collection view layout to put my nose into it |
@LivioGama thanks for trying, much appreciated. |
When I was looking into this (another great UI component from @roberthein) I saw this issue and wonderd. Hm.. That is strange. IGListKit is still just data driven backing for UICollectionView and BouncyLayout is still just a modular layout for UICollectionView. Why would that not work together? Spoiler. It does :) What have I done? Result: Enough joking. If you guys could reproduce your problem in a fork of that project I will gladly help. |
It work for simple cases, like a feed with one column. Try a grid of 2 columns. |
@heumn Yes I have a grid with 3 columns. This layout turns it on into a single column grid. |
Thanks @LivioGama @otymartin. So I guess this is related to #14 ? I will look into it as well :) Works in my usecase (with IGListKit, but seems stranger things are happening with headers and different sections) |
Yeah, there are some caching issues here somewhere... I will dig more tomorrow when I have time :) |
@heumn that would be wicked awesome if you could make it work with grid IGList layout :) |
@otymartin I have this thing called work on weekdays, but I will look into this on Saturday and Sunday :) |
@heumn I can respect that. look forward to see what you pull off |
This should be fixed in 2.3.0. |
@roberthein
Hey how can I use this with IGListCollectionViewLayout?
Would appreciate some pointers.
I tried subclassing but i get errors
The text was updated successfully, but these errors were encountered: