Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit this driver to https://github.com/micropython/micropython-lib drivers #33

Open
freemansoft opened this issue Jan 29, 2023 · 2 comments

Comments

@freemansoft
Copy link
Contributor

Can you submit this file to https://github.com/micropython/micropython-lib/tree/master/micropython/drivers/display Then it would be near the SSD1306 driver.

You could submit the file itself or ask if they would link it as a submodule like they do for many of the other mainline code like TinyUSB

@robert-hh
Copy link
Owner

I could try that. There is a difference to TinyUSB. The latter is used for the USB support of the firmware and therefore mandatory. SSD1306.py or SH1106 are "just" an optional drivers, which can be used and copied to the board if needed.

@freemansoft
Copy link
Contributor Author

In theory, the easiest thing to do is to just submit the driver to micropython-lib as an addition and then maintain it there. The micropython-lib team would probably just rather have everything reside there.

You are right. TinyUSB is different but really that particular library is cross-platform and used a bunch of places so I provided a lousy example.

I wanted to reference your driver file in a project without copying it in and without doing some fancy scripting. I added it as a git module so your file gets pulled into my working directory when checking out my repo. https://github.com/freemansoft/ESP8266-MicroPython/tree/main/freemometer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants