-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminology and luma.core.virtual.viewport #116
Comments
Viewport as defined in wikipedia is correct, of course. In luma.core, if you treat If you take a snippet as follows: virtual = viewport(device, width=device.width, height=768)
for _ in range(2):
with canvas(virtual) as draw:
draw.text((0, 0), "A long time ago", fill="white")
draw.text((0, 12), "in a galaxy far", fill="white")
draw.text((0, 24), "far away....", fill="white") I read this as "create a virtual device with a viewport onto the device, sized as ...". Strictly speaking |
Ok If I'm the only one understanding viewport this way, it's not a problem. |
No no, it's good that you're picking stuff up like this. If we can make the documentation and the code clearer as a result, then it's better for everyone who comes to subsequently use it. Have a think how it could be changed to be consistent with the wikipedia definition. |
Hi !
As a beginner, I'm trying to understand luma.core, and I'm learning the various concepts and terminology used for GUI.
One thing suprised me: If I read the viewport's page on Wikipedia, it's not the same concept as I understand it in caroussel.py or crawl.py.
From wikipedia:
But in caroussel.py, the viewport is larger than the visualization device.
Am I wrong ?
The text was updated successfully, but these errors were encountered: