Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of load_table() #38

Closed
jamesaoverton opened this issue Mar 11, 2025 · 1 comment · Fixed by #42
Closed

Improve performance of load_table() #38

jamesaoverton opened this issue Mar 11, 2025 · 1 comment · Fixed by #42
Assignees

Comments

@jamesaoverton
Copy link
Contributor

Anecdotally, I'm finding rltbl load to be slower than I expect. There are two things that I think will help:

  1. Wait to CREATE TRIGGER until after INSERT
  2. INSERT multiple rows at a time, limited by the number of parameters allows in a SQLite query (see Splitup code #9 https://www.sqlite.org/limits.html)
@lmcmicu
Copy link
Collaborator

lmcmicu commented Mar 17, 2025

Just a small note regarding 1: In the case where we are asked to load an already existing table, we should add a drop trigger if exists statement before the create table if not exists statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants