Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should cpt.var allow minseglen = 1? #57

Open
Eric6346 opened this issue Jun 2, 2021 · 1 comment
Open

Should cpt.var allow minseglen = 1? #57

Eric6346 opened this issue Jun 2, 2021 · 1 comment
Assignees

Comments

@Eric6346
Copy link

Eric6346 commented Jun 2, 2021

For the Normal assumption with unknown mean, assuming the length of the time series is at least 2, cpt.var should allow segments of length 1. This would rarely make any difference in practice, but in theory, I don't think there's anything wrong with segments of length 1.

@rkillick
Copy link
Owner

rkillick commented Jun 3, 2021

Thanks for raising this. I think that you are correct that with a global mean we can have the minimum segment length at 1. We would need to catch a variance of 0 if a single datapoint has the same value as the global mean but that is doable. I'll put it on the list of things to do.

@rkillick rkillick self-assigned this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants