-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
did you consider to integrate kvision with ktor client? #523
Comments
I did some tests and this seems not an issue now. the size of my bundle.js is: my methodologyrequirements:windows 10 gradle command
the added script looks like this
gradle dependencies
and here are imports I've added
other testdid the test with this too, and my bundle.js is 422 KB so it's pretty decent. What do you think? Are the tests valid for KVision? |
In general nothing stops you from using Ktor client. KVision REST client is totally optional. If you prefer Ktor and don't mind a bit larger bundle size, you can use it without any problems. So the question is - what kind of integration do you think of? |
I thought it would enable more feature out of the box and limit those that are actually duplicated like rest api calls. Since it is Jetbrains, this will get official support and in the end it should be easier to maintain. |
But KVision doesn't use rest api calls internally. So there is nothing to replace. Of course we could drop kvision-rest module, but it would only break compatibility with existing apps. The fullstack interfaces are based on fetch api directly and it would be probably to complicated to use ktor client instead. So in the end I think currently there is nothing to do with this issue. Everyone is free to use Ktor client with KVision apps. |
I think its good idea. It provides lot of tools for clients like cookies management, authentication, logging, web sockets, caching.
Do you see a reason why this is not good idea?
The text was updated successfully, but these errors were encountered: