-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code - tracker #52
Labels
refactor
Code needs refactoring
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue tracks code to refactor.
Documentation of structs should be Doxygen compliant (
//<
instead of//
)Unify "instruction" abbreviation
instr
->insn
.Run
clang-format
also over hand-written files. In case they were edited with indent style ignoring editors (e.g. vim)Enum names are sometimes all uppercase sometimes camel case. Should be all camel case.
Add
const
,RZ_BORROW
etc. qualifiers to all functions.Set internal functions to
RZ_IPI
instead ofRZ_API
Fix grammar/spelling issues (
handwritten
->hand-written
)Move the foloowing pattern in its own function
Move the following pattern in its own function:
Replaced
"..".format()
patterns withf"..."
formatting in Generate instruction templates as C structs #60Add functions which wrap code into a c-block/function/switch-case. (No longer needed since Generate instruction templates as C structs #60?)
Refactor
parse_instruction()
The method for parsing a Duplex or normal instruction are almost the same.
The method should be in
InstructionTemplate
from whichDuplexInstruction
andInstruction
inherit.Methods in question:
rz-hexagon/DuplexInstruction.py
Line 99 in 7df09f5
rz-hexagon/Instruction.py
Line 106 in 7df09f5
Update license date
Remove or include out-commented code (mostly logs)
The text was updated successfully, but these errors were encountered: