Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ht and buffer reading faster #4386

Open
Rot127 opened this issue Mar 25, 2024 · 0 comments
Open

Make ht and buffer reading faster #4386

Rot127 opened this issue Mar 25, 2024 · 0 comments
Labels
enhancement New feature or request performance A performance problem/enhancement

Comments

@Rot127
Copy link
Member

Rot127 commented Mar 25, 2024

Is your feature request related to a problem? Please describe.

In the callgrind of #4385 one can see that 30% execution time are due to ht_insert and 50% due to rz_buf_read_at.
Since these functions are potentially used very often in algorithms (in this example debug symbol processing), they should be more efficient if possible.

Describe the solution you'd like

Check ht_insert and the read component of the IO layer for inefficiencies.
At least for the hash table it might be even worth considering to replace it with another HT model.
This talk is for C++, but maybe worth a watch.

Describe alternatives you've considered

Doing nothing and just try to minimize the buffer reading and ht usage. But this is not really practical and hard to code.

Additional context

None

@Rot127 Rot127 added enhancement New feature or request performance A performance problem/enhancement labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance A performance problem/enhancement
Projects
None yet
Development

No branches or pull requests

1 participant