-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Error handling doesn't work and crashes the app #281
Comments
Any update on this? Experiencing the same issue. |
@markcruz389 Nothing new on my side and I'm still trying to find a solution. |
I think it's because the current version of rive-react-native does not support the new architecture in Expo 52. |
Thanks for your answer @weizhe412 👍 The problem is SDK 52 change so much things (in the right way) that I can't reject it and set newArchEnabled to false. So we need to wait for new architecture support to use rive-react-native in updated project 😞 |
Description
Hi 👋
<Rive>
component allows us (normally) to handle some errors (RNRiveErrorType):But instead of displaying a warning and/or handling error with
onError
, the app crashes instantly with any of the errors listed above 😕Example
The app crash instantly with something like that:
Repository
To reproduce, I created a rive playground: https://github.com/guval-gh/rive-playground
And the last example (Example 7) crash: https://github.com/guval-gh/rive-playground/blob/main/app/example7.tsx
Expected behavior
I expect my log to be displayed in the case of onError:
I expect that all the error cases that can be handled via onError won't cause the app to crash.
Screenshots
As soon as I try to go to the screen of the previous example, the app crashes:
Crash_on_error.mp4
Device
Additional context
Crash appear on:
Also tested on
rive-react-native
versions:8.0.0
and8.1.0
The text was updated successfully, but these errors were encountered: