Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open-source rive_common Github repo #361

Open
ChristianEdwardPadilla opened this issue Feb 28, 2024 · 3 comments
Open

Open-source rive_common Github repo #361

ChristianEdwardPadilla opened this issue Feb 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ChristianEdwardPadilla
Copy link

The listed repository on pub for rive_common is https://github.com/rive-app/rive-flutter (this repo). However, AFAICT the source for rive_common is not located here.

Most Flutter apps aren't affected because they can happily use pub get, but build systems which want to build from a Github source-of-truth cannot build rive-flutter currently.

Open-sourcing rive_common (wherever it lives, presumably in a private Github repo) would fix this issue.

@ChristianEdwardPadilla ChristianEdwardPadilla added the bug Something isn't working label Feb 28, 2024
@gardenofwine
Copy link

This is affecting my project as well, thanks for creating this issue.

@ChristianEdwardPadilla ChristianEdwardPadilla changed the title Open-source rive_common Open-source rive_common Github repo Feb 28, 2024
@ChristianEdwardPadilla
Copy link
Author

Changed the title to clarify that rive_common is open source (the source can be downloaded directly from the package's pub.dev page, or via pub get), it's just that the source-of-truth itself - presumably a private Github repo- is not public.

@HayesGordon
Copy link
Contributor

Hi all,

Thanks for raising the issue and providing information on why this is needed.

This is something that we can definitely look into doing, but it will require some engineering effort as there are some considerations on our side. We're currently prioritizing some other work and I can't give a timeline on when this will be done. But we will revisit this as soon as we can.

@HayesGordon HayesGordon added enhancement New feature or request and removed bug Something isn't working labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants