Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency on should_inc_minstret in the stepper. #783

Open
pmundkur opened this issue Mar 10, 2025 · 0 comments
Open

Fix dependency on should_inc_minstret in the stepper. #783

pmundkur opened this issue Mar 10, 2025 · 0 comments

Comments

@pmundkur
Copy link
Collaborator

should_inc_minstret is defined in riscv_smcntrpmf.sail i.e. a file for an extension, but used in riscv_step.sail.

This is unfortunate: core functionality should ideally not depend on functions defined only in extensions.

Similarly for should_inc_mcycle and riscv_platform.sail.

Discovered while rebasing #755.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmundkur