Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement for print-string-secret-key-deprecation #413

Open
trevor opened this issue Aug 18, 2020 · 1 comment · May be fixed by #415
Open

enhancement for print-string-secret-key-deprecation #413

trevor opened this issue Aug 18, 2020 · 1 comment · May be fixed by #415

Comments

@trevor
Copy link
Contributor

trevor commented Aug 18, 2020

print-string-secret-key-deprecation now prints:

"WARNING: The secret key for the session cookie store should be a"
"byte array.\nString secret keys have been deprecated."

It took some time to track down where this warning was coming from. A helpful modification may be something along the lines:

"WARNING (library 'ring' <version>): The secret key for the session cookie store should be a"
"byte array.\nString secret keys have been deprecated."
@weavejester
Copy link
Member

That's a good idea.

@isdanni isdanni linked a pull request Aug 20, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] enhance print-string-secrect-key-deprecation isdanni/ring
2 participants
@trevor @weavejester